From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97073C43387 for ; Fri, 14 Dec 2018 16:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E795D2070B for ; Fri, 14 Dec 2018 16:03:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VxIgAcPD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729801AbeLNQDD (ORCPT ); Fri, 14 Dec 2018 11:03:03 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37598 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727698AbeLNQDC (ORCPT ); Fri, 14 Dec 2018 11:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=473eeP3GI0MvI00VeEWqWlDLTMjlqViE4k7xzs1OzlQ=; b=VxIgAcPDPrV3bTN/0I2bUe1gA ORfdLOKc5aSksYGx0t9Nu+Y1RI7HVHSnOkkLrywxvT0hCPMNXuEdj35ekYJC9aluz0JmxZVakjnpT HAmTTCyQu3+kCBGy9AaNTwkmYR0QMy0Z7OyOBLVRF3iyGoB34/cwVTZaQr0Jw4T/2a00M=; Received: from n2100.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:4f86]:51941) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1gXpvS-0000gr-Lb; Fri, 14 Dec 2018 16:02:54 +0000 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1gXpvP-0005Tf-Ur; Fri, 14 Dec 2018 16:02:52 +0000 Date: Fri, 14 Dec 2018 16:02:50 +0000 From: Russell King - ARM Linux To: Antoine Tenart Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, Baruch Siach Subject: Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports Message-ID: <20181214160249.GD26090@n2100.armlinux.org.uk> References: <20181214093451.26314-1-antoine.tenart@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181214093451.26314-1-antoine.tenart@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote: > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do so. This patch fixes it. > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") > Cc: Baruch Siach > Signed-off-by: Antoine Tenart Looking at net-next, I think there's more to be fixed here: case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: case PHY_INTERFACE_MODE_SGMII: ... phylink_set(mask, 10000baseT_Full); Is that really true? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up