From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60154C43387 for ; Fri, 14 Dec 2018 16:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE184206E0 for ; Fri, 14 Dec 2018 16:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729960AbeLNQRp (ORCPT ); Fri, 14 Dec 2018 11:17:45 -0500 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:59016 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbeLNQRp (ORCPT ); Fri, 14 Dec 2018 11:17:45 -0500 Received: from dalias by brightrain.aerifal.cx with local (Exim 3.15 #2) id 1gXq9c-0004g6-00; Fri, 14 Dec 2018 16:17:32 +0000 Date: Fri, 14 Dec 2018 11:17:32 -0500 From: Rich Felker To: Bernd Petrovitsch Cc: John Paul Adrian Glaubitz , Andy Lutomirski , X86 ML , LKML , Linux API , "H. Peter Anvin" , Peter Zijlstra , Borislav Petkov , Florian Weimer , Mike Frysinger , "H. J. Lu" , x32@buildd.debian.org, Arnd Bergmann , Will Deacon , Catalin Marinas , Linus Torvalds Subject: Re: Can we drop upstream Linux x32 support? Message-ID: <20181214161732.GY23599@brightrain.aerifal.cx> References: <70bb54b2-8ed3-b5ee-c02d-6ef66c4f27eb@physik.fu-berlin.de> <20181213160242.GV23599@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2018 at 03:13:10PM +0100, Bernd Petrovitsch wrote: > On 13/12/2018 17:02, Rich Felker wrote: > > On Tue, Dec 11, 2018 at 11:29:14AM +0100, John Paul Adrian Glaubitz wrote: > >> I can't say anything about the syscall interface. However, what I do know > >> is that the weird combination of a 32-bit userland with a 64-bit kernel > >> interface is sometimes causing issues. For example, application code usually > >> expects things like time_t to be 32-bit on a 32-bit system. However, this > > IMHO this just historically grown (as in "it has been forever that way" > - it sounds way better in Viennese dialect though;-). > > >> isn't the case for x32 which is why code fails to build. > > > > I don't see any basis for this claim about expecting time_t to be > > 32-bit. I've encountered some programs that "implicitly assume" this > > by virtue of assuming they can cast time_t to long to print it, or > > similar. IIRC this was an issue in busybox at one point; I'm not sure > > if it's been fixed. But any software that runs on non-Linux unices has > > long been corrected. If not, 2038 is sufficiently close that catching > > and correcting any such remaining bugs is more useful than covering > > them up and making the broken code work as expected. > > Yup, unconditionally providing 64bit > time_t/timespec/timeval/...-equivalents with libc and syscall support > also for 32bit architectures (and deprecating all 32bit versions) should > be the way to go. > > FWIW I have > ---- snip ---- > #if defined __x86_64__ > # if defined __ILP32__ // x32 > # define PRI_time_t "lld" // for time_t > # define PRI_nsec_t "lld" // for tv_nsec in struct timespec > # else // x86_64 > # define PRI_time_t "ld" // for time_t > # define PRI_nsec_t "ld" // for tv_nsec in struct timespec > # endif > #else // i[3-6]68 > # define PRI_time_t "ld" // for time_t > # define PRI_nsec_t "ld" // for tv_nsec in struct timespec > #endif > ---- snip ---- > in my userspace code for printf() and friends - I don't know how libc's > react to such a patch (and I don't care for the name of the macros as > long it's obviously clear for which type they are). > I assume/fear we won't get additional modifiers into the relevant > standards for libc types (as they are far more like pid_t, uid_t etc.). > And casting to u/intmaxptr_t to get a defined printf()-modifier doesn't > look appealing to me to "solve" such issues. This is all useless (and wrong since tv_nsec is required to have type long as part of C and POSIX, regardless of ILP32-vs-LP64; that's a bug in glibc's x32). Just do: printf("%jd", (intmax_t)t); Saving 2 or 3 insns (for sign or zero extension) around a call to printf is not going to make any measurable difference to performance or any significant difference to size, and it's immeasurably more readable than the awful PRI* macros and the adjacent-string-concatenation they rely on. Rich