* [PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-15 7:19 Yangtao Li
2018-12-15 19:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-15 7:19 UTC (permalink / raw)
To: davem, kuznet, yoshfuji; +Cc: netdev, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
net/ipv4/ipconfig.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 88212615bf4c..fcb817d0eb24 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1361,18 +1361,7 @@ static int ntp_servers_seq_show(struct seq_file *seq, void *v)
}
return 0;
}
-
-static int ntp_servers_seq_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ntp_servers_seq_show, NULL);
-}
-
-static const struct file_operations ntp_servers_seq_fops = {
- .open = ntp_servers_seq_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ntp_servers_seq);
#endif /* CONFIG_PROC_FS */
/*
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-15 7:19 [PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-15 19:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-15 19:21 UTC (permalink / raw)
To: tiny.windzz; +Cc: kuznet, yoshfuji, netdev, linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Date: Sat, 15 Dec 2018 02:19:53 -0500
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-15 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-15 7:19 [PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-15 19:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).