linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: renesas_usbhs: add support for RZ/G2E
@ 2018-12-14  8:27 Fabrizio Castro
  2018-12-14  9:13 ` Yoshihiro Shimoda
  2018-12-15 15:17 ` Simon Horman
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrizio Castro @ 2018-12-14  8:27 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Felipe Balbi, Yoshihiro Shimoda
  Cc: Fabrizio Castro, Simon Horman, Jarkko Nikula, Chris Brandt,
	Arnd Bergmann, linux-usb, linux-kernel, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
the PLL reset by the UGCTRL register like R-Car E3, therefore add
r8a774c0 support in a similar fashion to what was done for the
r8a77990.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/usb/renesas_usbhs/common.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 2ff7991..249fbee 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -540,6 +540,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
  */
 static const struct of_device_id usbhs_of_match[] = {
 	{
+		.compatible = "renesas,usbhs-r8a774c0",
+		.data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
+	},
+	{
 		.compatible = "renesas,usbhs-r8a7790",
 		.data = (void *)USBHS_TYPE_RCAR_GEN2,
 	},
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] usb: renesas_usbhs: add support for RZ/G2E
  2018-12-14  8:27 [PATCH] usb: renesas_usbhs: add support for RZ/G2E Fabrizio Castro
@ 2018-12-14  9:13 ` Yoshihiro Shimoda
  2018-12-15 15:17 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2018-12-14  9:13 UTC (permalink / raw)
  To: Fabrizio Castro, Greg Kroah-Hartman, Felipe Balbi
  Cc: Fabrizio Castro, Simon Horman, Jarkko Nikula, Chris Brandt,
	Arnd Bergmann, linux-usb, linux-kernel, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Hi Fabrizio,

> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:27 PM
> 
> HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
> one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
> the PLL reset by the UGCTRL register like R-Car E3, therefore add
> r8a774c0 support in a similar fashion to what was done for the
> r8a77990.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thank you for the patch!

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/usb/renesas_usbhs/common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 2ff7991..249fbee 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -540,6 +540,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
>   */
>  static const struct of_device_id usbhs_of_match[] = {
>  	{
> +		.compatible = "renesas,usbhs-r8a774c0",
> +		.data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
> +	},
> +	{
>  		.compatible = "renesas,usbhs-r8a7790",
>  		.data = (void *)USBHS_TYPE_RCAR_GEN2,
>  	},
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: renesas_usbhs: add support for RZ/G2E
  2018-12-14  8:27 [PATCH] usb: renesas_usbhs: add support for RZ/G2E Fabrizio Castro
  2018-12-14  9:13 ` Yoshihiro Shimoda
@ 2018-12-15 15:17 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-12-15 15:17 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Greg Kroah-Hartman, Felipe Balbi, Yoshihiro Shimoda,
	Jarkko Nikula, Chris Brandt, Arnd Bergmann, linux-usb,
	linux-kernel, Geert Uytterhoeven, Chris Paterson, Biju Das,
	linux-renesas-soc

On Fri, Dec 14, 2018 at 08:27:03AM +0000, Fabrizio Castro wrote:
> HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
> one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
> the PLL reset by the UGCTRL register like R-Car E3, therefore add
> r8a774c0 support in a similar fashion to what was done for the
> r8a77990.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-15 15:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14  8:27 [PATCH] usb: renesas_usbhs: add support for RZ/G2E Fabrizio Castro
2018-12-14  9:13 ` Yoshihiro Shimoda
2018-12-15 15:17 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).