From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
stefan.popa@analog.com, alexandru.Ardelean@analog.com,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933
Date: Sun, 16 Dec 2018 12:16:31 +0000 [thread overview]
Message-ID: <20181216121631.5b30831f@archlinux> (raw)
In-Reply-To: <20181210212702.4160ff1f@archlinux>
On Mon, 10 Dec 2018 21:27:02 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Sat, 8 Dec 2018 16:19:59 -0200
> Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
>
> > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > converter, network analyzer.
> >
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > Signed-off-by: Gabriel Capella <gabriel@capella.pro>
> > Co-Developed-by: Gabriel Capella <gabriel@capella.pro>
> Device tree binding patches need to also go to the DT maintainers and list
> for review.
>
> This looks fine to me but they are the specialists in these!
>
> +cc Rob, Mark and DT list.
Long enough I think. This will be in my tree in a fashion I can rebase for
a week or so anyway so please still feel free to comment.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> Jonathan
> > ---
> > .../iio/impedance-analyzer/ad5933.txt | 26 +++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> > new file mode 100644
> > index 000000000000..5ff38728ff91
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> > @@ -0,0 +1,26 @@
> > +Analog Devices AD5933/AD5934 Impedance Converter, Network Analyzer
> > +
> > +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
> > +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5934.pdf
> > +
> > +Required properties:
> > + - compatible : should be one of
> > + "adi,ad5933"
> > + "adi,ad5934"
> > + - reg : the I2C address.
> > + - vdd-supply : The regulator supply for DVDD, AVDD1 and AVDD2 when they
> > + are connected together.
> > +
> > +Optional properties:
> > +- clocks : external clock reference.
> > +- clock-names : must be "mclk" if clocks is set.
> > +
> > +Example for a I2C device node:
> > +
> > + impedance-analyzer@0d {
> > + compatible = "adi,adxl345";
> > + reg = <0x0d>;
> > + vdd-supply = <&vdd_supply>;
> > + clocks = <&ref_clk>;
> > + clock-names = "mclk";
> > + };
>
next prev parent reply other threads:[~2018-12-16 12:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 18:18 [PATCH 0/3] Add devicetree support for ad5933 Marcelo Schmitt
2018-12-08 18:19 ` [PATCH 1/3] staging: iio: ad5933: change regulator binging for vref Marcelo Schmitt
2018-12-16 12:13 ` Jonathan Cameron
2018-12-08 18:19 ` [PATCH 2/3] staging: iio: ad5933: use clock framework for clock reference Marcelo Schmitt
2018-12-16 12:14 ` Jonathan Cameron
2018-12-08 18:19 ` [PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933 Marcelo Schmitt
2018-12-10 21:27 ` Jonathan Cameron
2018-12-16 12:16 ` Jonathan Cameron [this message]
2018-12-08 18:56 ` [PATCH 0/3] Add devicetree support " Marcelo Schmitt
2018-12-08 21:10 ` Greg KH
2018-12-10 21:27 ` Jonathan Cameron
2018-12-11 10:31 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216121631.5b30831f@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).