From: Petr Mladek <pmladek@suse.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] livepatch: fix non-static warnings
Date: Mon, 17 Dec 2018 12:49:22 +0100 [thread overview]
Message-ID: <20181217114922.km7dhpcuevjog3d3@pathway.suse.cz> (raw)
In-Reply-To: <72b8f2a4-9070-23d3-4e75-66e10b2d94b5@redhat.com>
On Fri 2018-12-14 16:34:23, Joe Lawrence wrote:
> Almost. We should only need to annotate with __noclone for those
> function definitions which the samples will be patching. As the commit
> message says, these correlate to klp_func.old_name functions found in
> klp_object.name objects (.ko modules or NULL for vmlinux).
>
> For the functions defined in samples/livepatch/*.c those would be:
>
> livepatch-callbacks-busymod.c :: busymod_work_func()
__noclone is not added to this function in v2. Well, I wonder
if it can be optimized when it is passed as a pointer.
> livepatch-shadow-mod.c :: dummy_alloc()
> livepatch-shadow-mod.c :: dummy_free()
> livepatch-shadow-mod.c :: dummy_check()
>
> So even though livepatch-shadow-fix2 further refines
> livepatch-shadow-fix1, the livepatch core is going to redirect the
> original dummy_*() calls defined by livepatch-shadow-mod.c in both fix1
> and fix2 cases. Ie, the fixes modules aren't patched, only the original.
Best Regards,
Petr
prev parent reply other threads:[~2018-12-17 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:56 [PATCH 1/2] livepatch: fix non-static warnings Nicholas Mc Guire
2018-12-14 16:56 ` [PATCH 2/2] livepatch: check kzalloc return values Nicholas Mc Guire
2018-12-14 21:39 ` Joe Lawrence
2018-12-17 11:41 ` Petr Mladek
2018-12-17 11:43 ` Miroslav Benes
2018-12-18 9:23 ` Jiri Kosina
2018-12-14 21:34 ` [PATCH 1/2] livepatch: fix non-static warnings Joe Lawrence
2018-12-14 21:51 ` Josh Poimboeuf
2018-12-14 22:03 ` Joe Lawrence
2018-12-15 8:50 ` Nicholas Mc Guire
2018-12-15 16:23 ` Joe Lawrence
2018-12-17 11:49 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217114922.km7dhpcuevjog3d3@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=hofrat@osadl.org \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).