linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: natechancellor@gmail.com, kernelpatch@126.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] staging: rtlwifi: convert to DEFINE_SHOW_ATTRIBUTE
Date: Mon, 17 Dec 2018 14:52:30 +0100	[thread overview]
Message-ID: <20181217135230.GA1836@kroah.com> (raw)
In-Reply-To: <20181215085635.27602-1-tiny.windzz@gmail.com>

On Sat, Dec 15, 2018 at 03:56:35AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  drivers/staging/rtlwifi/debug.c | 23 ++++++-----------------
>  1 file changed, 6 insertions(+), 17 deletions(-)

Always test build your patches so you do not get grumpy maintainers
telling you to not break the build :(

Please fix up.

greg k-h

  parent reply	other threads:[~2018-12-17 13:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15  8:56 [RESEND] staging: rtlwifi: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-15 12:08 ` kbuild test robot
2018-12-17 13:52 ` Greg KH [this message]
2018-12-20 21:24 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217135230.GA1836@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=kernelpatch@126.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=tiny.windzz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).