Re: [PATCH] media: dt-bindings: rcar-vin: Add R8A774C0 support

From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH] media: dt-bindings: rcar-vin: Add R8A774C0 support
Date: Mon, 17 Dec 2018 15:47:13 +0100	[thread overview]
Message-ID: <20181217144713.GR17972@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1544732519-6956-1-git-send-email-fabrizio.castro@bp.renesas.com>

Hi Fabrizio,

Thanks for your patch.

On 2018-12-13 20:21:59 +0000, Fabrizio Castro wrote:
> Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list
> of SoCs supported by rcar-vin driver.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 7c878ca..34dcd28 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -7,12 +7,13 @@ family of devices.
>  Each VIN instance has a single parallel input that supports RGB and YUV video,
>  with both external synchronization and BT.656 synchronization for the latter.
>  Depending on the instance the VIN input is connected to external SoC pins, or
> -on Gen3 platforms to a CSI-2 receiver.
> +on Gen3 and RZ/G2 platforms to a CSI-2 receiver.
>  
>   - compatible: Must be one or more of the following
>     - "renesas,vin-r8a7743" for the R8A7743 device
>     - "renesas,vin-r8a7744" for the R8A7744 device
>     - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a774c0" for the R8A774C0 device
>     - "renesas,vin-r8a7778" for the R8A7778 device
>     - "renesas,vin-r8a7779" for the R8A7779 device
>     - "renesas,vin-r8a7790" for the R8A7790 device
> @@ -60,10 +61,10 @@ The per-board settings Gen2 platforms:
>      - data-enable-active: polarity of CLKENB signal, see [1] for
>        description. Default is active high.
>  
> -The per-board settings Gen3 platforms:
> +The per-board settings Gen3 and RZ/G2 platforms:
>  
> -Gen3 platforms can support both a single connected parallel input source
> -from external SoC pins (port@0) and/or multiple parallel input sources
> +Gen3 and RZ/G2 platforms can support both a single connected parallel input
> +source from external SoC pins (port@0) and/or multiple parallel input sources
>  from local SoC CSI-2 receivers (port@1) depending on SoC.
>  
>  - renesas,id - ID number of the VIN, VINx in the documentation.
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas Söderlund