From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Miroslav Benes <mbenes@suse.cz>
Subject: Re: objtool warnings for kernel/trace/trace_selftest_dynamic.o
Date: Mon, 17 Dec 2018 12:16:38 -0600 [thread overview]
Message-ID: <20181217181638.dfexg6mkmbfyzfli@treble> (raw)
In-Reply-To: <20181217180434.GS25620@tassilo.jf.intel.com>
On Mon, Dec 17, 2018 at 10:04:34AM -0800, Andi Kleen wrote:
> On Mon, Dec 17, 2018 at 11:39:00AM -0600, Josh Poimboeuf wrote:
> > On Sun, Dec 16, 2018 at 07:33:11PM +0100, Arnd Bergmann wrote:
> > > Hi Josh,
> > >
> > > In randconfig tests with gcc-8.1, I get this warning every
> > > few hundred builds, tried it on both next/master and 4.19.y-stable:
> > >
> > > kernel/trace/trace_selftest_dynamic.o: warning: objtool:
> > > trace_selftest_dynamic_test_func()+0x5: call without frame pointer
> > > save/setup
> > > kernel/trace/trace_selftest_dynamic.o: warning: objtool:
> > > trace_selftest_dynamic_test_func2()+0x5: call without frame pointer
> > > save/setup
> > >
> > > $ objdump -dr build/x86/0x90C84554_defconfig/kernel/trace/trace_selftest_dynamic.o
> > >
> > > build/x86/0x90C84554_defconfig/kernel/trace/trace_selftest_dynamic.o:
> > > file format elf64-x86-64
> > >
> > > Disassembly of section .text:
> > >
> > > 0000000000000000 <trace_selftest_dynamic_test_func>:
> > > 0: e8 00 00 00 00 callq 5
> > > <trace_selftest_dynamic_test_func+0x5>
> > > 1: R_X86_64_PC32 __fentry__-0x4
> > > 5: e8 00 00 00 00 callq a
> > > <trace_selftest_dynamic_test_func+0xa>
> > > 6: R_X86_64_PC32 __sanitizer_cov_trace_pc-0x4
> > > a: 31 c0 xor %eax,%eax
> > > c: c3 retq
> > > d: 0f 1f 00 nopl (%rax)
> > >
> > > 0000000000000010 <trace_selftest_dynamic_test_func2>:
> > > 10: e8 00 00 00 00 callq 15
> > > <trace_selftest_dynamic_test_func2+0x5>
> > > 11: R_X86_64_PC32 __fentry__-0x4
> > > 15: e8 00 00 00 00 callq 1a
> > > <trace_selftest_dynamic_test_func2+0xa>
> > > 16: R_X86_64_PC32 __sanitizer_cov_trace_pc-0x4
> > > 1a: 31 c0 xor %eax,%eax
> > > 1c: c3 retq
> > >
> > > I found this reported in
> > > http://kisskb.ellerman.id.au/kisskb/buildresult/13499139/, but could
> > > not find an existing fix or analysis.
> >
> > Thanks for reporting this Arnd.
> >
> > The problem is that, for some reason, __noclone is preventing GCC from
> > creating frame pointers for these functions. Miroslav said that
>
> That seems weird.
>
> Are you sure it's not just because they are empty? AFAIK
> gcc doesn't necessarily generate frame pointers for empty functions.
I suspected that it was because they're empty, however I didn't see this
warning for other leaf functions. The sancov plugin is presumably
taking care of adding frame pointers where needed. Also, adding
-mno-omit-leaf-frame-pointer didn't fix it.
And anyway I confirmed that it was fixed by removing __noclone.
> > __noclone is not recommended by GCC developers, and that __used can be
> > used instead for the same purpose:
> >
> > https://lkml.kernel.org/r/alpine.LSU.2.21.1812171256390.3087@pobox.suse.cz
> >
> > Andi,
> >
> > is __noclone really needed here, since the functions aren't static? Or
> > does LTO cause them to be treated like static functions?
>
> Yes LTO causes the to be treated like static functions.
>
> I guess noclone is unlikely to be really needed here because these
> functions are unlikely to be cloned.
>
> So as a workaround it could be removed.
>
> But note we have other noclone functions in the tree (like in KVM)
> which actually need it.
How about we just use the __used attribute then? It seems to have the
same result of preventing IPA optimizations (without the weird side
effect of missing frame pointers).
--
Josh
next prev parent reply other threads:[~2018-12-17 18:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 18:33 objtool warnings for kernel/trace/trace_selftest_dynamic.o Arnd Bergmann
2018-12-17 17:39 ` Josh Poimboeuf
2018-12-17 18:04 ` Andi Kleen
2018-12-17 18:16 ` Josh Poimboeuf [this message]
2018-12-17 19:29 ` Peter Zijlstra
2018-12-17 20:55 ` Andi Kleen
2018-12-17 22:35 ` Peter Zijlstra
2018-12-17 23:59 ` Andi Kleen
2018-12-18 9:19 ` Peter Zijlstra
2018-12-18 21:22 ` Andi Kleen
2018-12-17 21:31 ` Josh Poimboeuf
2018-12-17 22:36 ` Steven Rostedt
2018-12-18 0:06 ` Andi Kleen
2018-12-18 2:49 ` Josh Poimboeuf
2018-12-18 4:22 ` Andi Kleen
2018-12-18 9:28 ` Miroslav Benes
2018-12-18 12:15 ` Martin Jambor
2018-12-18 12:31 ` Steven Rostedt
2018-12-18 14:01 ` Josh Poimboeuf
2018-12-18 21:20 ` Andi Kleen
2018-12-19 3:44 ` Sean Christopherson
2018-12-19 17:31 ` Martin Jambor
2018-12-18 21:15 ` Andi Kleen
2018-12-18 21:57 ` Steven Rostedt
2018-12-18 22:13 ` Andi Kleen
2018-12-18 22:16 ` Steven Rostedt
2018-12-18 23:26 ` Andi Kleen
2018-12-18 23:40 ` Steven Rostedt
2018-12-19 17:38 ` Martin Jambor
2018-12-18 3:05 ` Josh Poimboeuf
2018-12-17 23:54 ` Andi Kleen
2018-12-17 21:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217181638.dfexg6mkmbfyzfli@treble \
--to=jpoimboe@redhat.com \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).