From: Christoph Hellwig <hch@infradead.org>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 1/7] ACPI: Allow CONFIG_PCI to be unset for reboot
Date: Mon, 17 Dec 2018 23:31:39 -0800 [thread overview]
Message-ID: <20181218073139.GA8612@infradead.org> (raw)
In-Reply-To: <20181218025606.32668-2-okaya@kernel.org>
> +#ifdef CONFIG_PCI
> + unsigned int devfn;
> + struct pci_bus *bus0;
> +
> /* The reset register can only live on bus 0. */
> bus0 = pci_find_bus(0, 0);
> if (!bus0)
> @@ -44,8 +47,9 @@ void acpi_reboot(void)
> /* Write the value that resets us. */
> pci_bus_write_config_byte(bus0, devfn,
> (rr->address & 0xffff), reset_value);
> +#endif
This would be a lot cleaner if this was split into a little helper
function.
next prev parent reply other threads:[~2018-12-18 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181218025606.32668-1-okaya@kernel.org>
2018-12-18 2:56 ` [PATCH v11 1/7] ACPI: Allow CONFIG_PCI to be unset for reboot Sinan Kaya
2018-12-18 7:31 ` Christoph Hellwig [this message]
2018-12-19 22:21 ` Sinan Kaya
2018-12-18 2:56 ` [PATCH v11 2/7] ACPI / OSL: Stub out acpi_os_(read/write)_pci_configurations() Sinan Kaya
2018-12-18 7:32 ` Christoph Hellwig
2018-12-19 22:22 ` Sinan Kaya
2018-12-18 2:56 ` [PATCH v11 3/7] PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set Sinan Kaya
2018-12-18 2:56 ` [PATCH v11 4/7] ACPICA: Remove PCI bits from ACPICA when CONFIG_PCI is unset Sinan Kaya
2018-12-18 2:56 ` [PATCH v11 5/7] arm64: select ACPI PCI code only both features are enabled Sinan Kaya
2018-12-18 2:56 ` [PATCH v11 6/7] ACPI/IORT: Stub out ACS functions when CONFIG_PCI is not set Sinan Kaya
2018-12-18 7:44 ` Hanjun Guo
2018-12-18 12:00 ` Lorenzo Pieralisi
2018-12-18 2:56 ` [PATCH v11 7/7] ACPI: Make PCI slot detection driver depend on PCI Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218073139.GA8612@infradead.org \
--to=hch@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).