From: "Numan Demirdöğen" <email@example.com> To: Pavel Machek <firstname.lastname@example.org> Cc: email@example.com, Waiman.Long@hpe.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate Date: Tue, 18 Dec 2018 10:23:02 +0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20181202222809.GA29467@amd> [-- Attachment #1: Type: text/plain, Size: 2660 bytes --] Sun, 2 Dec 2018 23:28:09 +0100 tarihinde Pavel Machek <firstname.lastname@example.org> yazdı: >On Fri 2018-11-30 15:44:55, Numan Demirdöğen wrote: >> Sun, 28 Oct 2018 22:06:54 +0300 tarihinde >> Numan Demirdöğen <email@example.com> yazdı: >> >> >Thu, 25 Oct 2018 09:49:03 +0200 tarihinde >> >Pavel Machek <firstname.lastname@example.org> yazdı: >> > >> >> Hi! >> >> >> >> Here's problem bisected down to: >> >> >> >> commit 9d659ae14b545c4296e812c70493bfdc999b5c1c >> >> Author: Peter Zijlstra <email@example.com> >> >> Date: Tue Aug 23 14:40:16 2016 +0200 >> >> >> >> locking/mutex: Add lock handoff to avoid starvation >> >> >> >> Implement lock handoff to avoid lock starvation. >> >> >> >> Numan, I assume revert of that patch on the 4.18 kernel still >> >> makes it work? >> >> >> > >> >Unfortunately, I could not revert >> >9d659ae14b545c4296e812c70493bfdc999b5c1c on kernels from 4.18.16 to >> >4.10-rc1 because there were too much conflicts, which I could not >> >solve as an "average Joe". I tried >> >a3ea3d9b865c2a8f7fe455c7fa26db4b6fd066e3 which is parent of >> >9d659ae14b545c4296e812c70493bfdc999b5c1c and succeeded to compile >> >kernel. >> > >> >git checkout a3ea3d9b865c2a8f7fe455c7fa26db4b6fd066e3 >> > >> >Then, I compiled kernel and rebooted with it. I tried a couples of >> >times suspending and resuming, all of the time keyboard worked as >> >expected. >> > >> >> With this one line patch from Takashi Iwai, keyboard is working as >> expected after resuming from suspend/hibernate. >> >> --- a/kernel/locking/mutex.c >> +++ b/kernel/locking/mutex.c >> @@ -59,7 +59,7 @@ EXPORT_SYMBOL(__mutex_init); >> * Bit2 indicates handoff has been done and we're waiting for >> pickup. */ >> #define MUTEX_FLAG_WAITERS 0x01 >> -#define MUTEX_FLAG_HANDOFF 0x02 >> +#define MUTEX_FLAG_HANDOFF 0x00 >> #define MUTEX_FLAG_PICKUP 0x04 >> >> #define MUTEX_FLAGS 0x07 >> >> >> Thanks in advance and regards, > >Ok. So it is a regression, and you can ask Linus to apply this >.. but... that's kind of heavy solution. Peter, do you have any other >ideas? > > Pavel Hi, I did not mention the one line patch from Takashi Iwai as a means of fix but as a hint. Sorry for misunderstanding. Here is a another hint from another user: I found that passing the options i8042.reset=1 i8042.dumbkbd=1 i8042.direct=1 results in the keyboard functioning after resume. However, there is a long delay before the keyboard or mouse will respond to input on the lock screen.  https://bugzilla.kernel.org/show_bug.cgi?id=195471#c39 -- Numan Demirdöğen [-- Attachment #2: Dijital OpenPGP imzasÄ± --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-18 7:23 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-31 18:53 PROBLEM: " Numan Demirdöğen 2018-08-31 19:16 ` Peter Zijlstra 2018-08-31 19:38 ` Numan Demirdöğen 2018-09-03 8:53 ` Numan Demirdöğen 2018-09-18 18:54 ` Pavel Machek 2018-10-19 7:20 ` Fw: " Numan Demirdöğen 2018-10-25 7:49 ` [regression, bisected] " Pavel Machek 2018-10-28 19:06 ` Numan Demirdöğen 2018-11-30 12:44 ` Numan Demirdöğen 2018-12-02 22:28 ` Pavel Machek 2018-12-18 7:23 ` Numan Demirdöğen [this message] 2019-03-14 19:54 ` Peter Zijlstra 2019-07-31 9:07 Numan Demirdöğen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Waiman.Long@hpe.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).