From: Shayenne Moura <shayenneluzmoura@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints
Date: Wed, 19 Dec 2018 15:29:43 -0200 [thread overview]
Message-ID: <20181219172943.yvccbanfeod3hcoj@smtp.gmail.com> (raw)
In-Reply-To: <20181219131254.GR21184@phenom.ffwll.local>
On 12/19, Daniel Vetter wrote:
> On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > This patch removes base.id prints from drm_display_mode
> > objects in i915 files. It removes dependency from drm_mode_object.
> >
> > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
>
> Again I think better to switch to DRM_MODE_FMT/ARG.
> -Daniel
>
This one has a different print style. Is it okay to change to DRM_MODE_FMT?
Best,
Shayenne
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 7f455bca528e..61dd7bb3fa85 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > for (i = 0; i < tabs; i++)
> > seq_putc(m, '\t');
> >
> > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > - mode->base.id, mode->name,
> > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > + mode->name,
> > mode->vrefresh, mode->clock,
> > mode->hdisplay, mode->hsync_start,
> > mode->hsync_end, mode->htotal,
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
next prev parent reply other threads:[~2018-12-19 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 13:38 [PATCH 4/7] drm: i915: Delete base.id prints Shayenne Moura
2018-12-19 13:09 ` Jani Nikula
2018-12-19 13:12 ` Daniel Vetter
2018-12-19 17:29 ` Shayenne Moura [this message]
2018-12-19 18:27 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219172943.yvccbanfeod3hcoj@smtp.gmail.com \
--to=shayenneluzmoura@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).