From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A398FC43387 for ; Thu, 20 Dec 2018 12:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 734DD21852 for ; Thu, 20 Dec 2018 12:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545308977; bh=4GOnTsdMJMvpkfhKbOHKC0Z80Z0cUSfaeDX/dlsfWeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XzwJUgUi0Rj5lLc16o4mOklhKvNutEIBVxC6pkA+z6V7z8VHOqSnIKlD7F/VEGPG3 StEUu/pQ3EDgmzt0BIZfJ31WTBA64HAlhDXAsP3cam22Vspm9OdvLeAX4XaXGdcm/e tQwwDsoZUPXHWlEZTnzirJt7HAdOklMAWu/frE2o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732146AbeLTM3g (ORCPT ); Thu, 20 Dec 2018 07:29:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:39686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731418AbeLTM3f (ORCPT ); Thu, 20 Dec 2018 07:29:35 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 539A2217D4; Thu, 20 Dec 2018 12:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545308974; bh=4GOnTsdMJMvpkfhKbOHKC0Z80Z0cUSfaeDX/dlsfWeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bfwtpOtdulxRZbBPS+kuxrrbAZfcgMqAWZOlrmKFb7HLfAbgK3koVIwEm926xN2HW /EpebR2O/sStb/GN5m3Lo08El19h9j+9DoZ1k6qgBywh8SI33iyn/gG26W/Yljn8hH aU6WpjzqTSmavZBCZfpP+rlOsrdha3/ePVagOHJE= Date: Thu, 20 Dec 2018 13:29:32 +0100 From: Greg KH To: Buland Singh Cc: clemens@ladisch.de, arnd@arndb.de, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable Message-ID: <20181220122932.GB17138@kroah.com> References: <20181220120524.30732-1-bsingh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181220120524.30732-1-bsingh@redhat.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 05:35:24PM +0530, Buland Singh wrote: > Commit '3d035f580699 ("drivers/char/hpet.c: allow user controlled mmap for > user processes")' introduced a new kernel command line parameter hpet_mmap, > that is required to expose the memory map of the HPET registers to > user-space. Unfortunately the kernel command line parameter 'hpet_mmap' is > broken and never takes effect due to missing '=' character in the __setup() > code of hpet_mmap_enable. > > Before this patch: > > dmesg output with the kernel command line parameter hpet_mmap=1 > > [ 0.204152] HPET mmap disabled > > dmesg output with the kernel command line parameter hpet_mmap=0 > > [ 0.204192] HPET mmap disabled > > After this patch: > > dmesg output with the kernel command line parameter hpet_mmap=1 > > [ 0.203945] HPET mmap enabled > > dmesg output with the kernel command line parameter hpet_mmap=0 > > [ 0.204652] HPET mmap disabled > > Fixes: 3d035f580699 ("drivers/char/hpet.c: allow user controlled mmap for user processes") > Signed-off-by: Buland Singh > --- > drivers/char/hpet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c > index 4a22b4b41aef..9bffcd37cc7b 100644 > --- a/drivers/char/hpet.c > +++ b/drivers/char/hpet.c > @@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str) > pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled"); > return 1; > } > -__setup("hpet_mmap", hpet_mmap_enable); > +__setup("hpet_mmap=", hpet_mmap_enable); This has _never_ worked? Since 3.13? Why not just remove the thing as it is obvious no one actually has ever used it. That would make the code even simpler :) thanks, greg k-h