From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B488DC43444 for ; Thu, 20 Dec 2018 15:37:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D4C7218D3 for ; Thu, 20 Dec 2018 15:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387854AbeLTPhh (ORCPT ); Thu, 20 Dec 2018 10:37:37 -0500 Received: from charybdis-ext.suse.de ([195.135.221.2]:21847 "EHLO suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729447AbeLTPhh (ORCPT ); Thu, 20 Dec 2018 10:37:37 -0500 Received: by suse.de (Postfix, from userid 1000) id 09C8A3CAF; Thu, 20 Dec 2018 16:37:34 +0100 (CET) Date: Thu, 20 Dec 2018 16:37:34 +0100 From: Oscar Salvador To: Michal Hocko Cc: Wei Yang , akpm@linux-foundation.org, vbabka@suse.cz, pavel.tatashin@microsoft.com, rppt@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm, page_alloc: Fix has_unmovable_pages for HugePages Message-ID: <20181220153731.mpc757cyf2zyr6fm@d104.suse.de> References: <20181217225113.17864-1-osalvador@suse.de> <20181219142528.yx6ravdyzcqp5wtd@master> <20181219233914.2fxe26pih26ifvmt@d104.suse.de> <20181220091228.GB14234@dhcp22.suse.cz> <20181220124925.itwuuacgztpgsk7s@d104.suse.de> <20181220130606.GG9104@dhcp22.suse.cz> <20181220134132.6ynretwlndmyupml@d104.suse.de> <20181220142124.r34fnuv6b33luj5a@d104.suse.de> <20181220143939.GA6210@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181220143939.GA6210@dhcp22.suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 03:39:39PM +0100, Michal Hocko wrote: > Yes, you are missing that this code should be as sane as possible ;) You > are right that we are only processing one pageorder worth of pfns and > that the page order is bound to HUGETLB_PAGE_ORDER _right_now_. But > there is absolutely zero reason to hardcode that assumption into a > simple loop, right? Of course, it makes sense to keep the code as sane as possible. This is why I said I was not against the change, but I wanted to see if I was missing something else besides the assumption. Thanks -- Oscar Salvador SUSE L3