From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948F2C43387 for ; Fri, 21 Dec 2018 02:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EB2121906 for ; Fri, 21 Dec 2018 02:36:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nl3DC+W1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390850AbeLUCgJ (ORCPT ); Thu, 20 Dec 2018 21:36:09 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46528 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388799AbeLUCgI (ORCPT ); Thu, 20 Dec 2018 21:36:08 -0500 Received: by mail-pg1-f196.google.com with SMTP id w7so1762996pgp.13 for ; Thu, 20 Dec 2018 18:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=D0MlURTt1nCvg8EFKNr+8mCnhzAm1tiCZAzywT9Mfr8=; b=Nl3DC+W1F5t+2H5wFgXxpJcesI0pR80bQa2En9Sf3PGcPmSOSpVViGSFg8lZmJ4+y7 81Y2M6eOlq4DEdCyWIFmRx4qRbXfH5EY5cnkSZWOyzfEyA6XCybo7bIaID8AhIgqtIyL wp+sh1kRm5NQnlnmXj6QkYmUn/2A0TxdWWUcg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=D0MlURTt1nCvg8EFKNr+8mCnhzAm1tiCZAzywT9Mfr8=; b=lb1ysSvtiUrKuLiZsdB/9GxL3va4VqWM6UC86xZpdhxtrgwjU0vDgeJspB9W5VeJbe /jNcJjXr7LIE45aj8QTX/iw3OBY/6Y27ZdM8V1u5YNHBmEvXNxlDWApM6OFzfJpyOLCv 41Hw4Sd2lcJEgUa690BDlbXIF2DM5ZmFsxz48a5wa64oDgek8631MwEgKo831+tpdPTB ZRTNeTYSJGKi2/fwlWTvqAz0sYAdsJOlYAs4avfl/BNo/S7g0tnq6pRwof/F97YiODIc hAEUJzOm0gGeQcgV3oACKCP3Y1FnvF+EEPvz+XlZ4KYzrjbgy4QAK3hJaUGX7kcIZvYB G8cw== X-Gm-Message-State: AA+aEWavVPx3nBnLZPzCQf9z0tLNFNdapfcmiSr1lZ/+wj8Qy2XHLPDn bpwfno/KNKv4ijZLsjGNQ+Ki X-Google-Smtp-Source: AFSGD/VdDzzOjEgiDcSVmGChhmKrJxSTOeceVHFlIibvWIzIdF1z0QZEFTFg10NZ5HZ2Cn2IZyWbaw== X-Received: by 2002:a62:db41:: with SMTP id f62mr677668pfg.123.1545359767807; Thu, 20 Dec 2018 18:36:07 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:810:d868:55e9:25e8:dbda:255b]) by smtp.gmail.com with ESMTPSA id h82sm41836555pfa.105.2018.12.20.18.36.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Dec 2018 18:36:07 -0800 (PST) Date: Fri, 21 Dec 2018 08:05:57 +0530 From: Manivannan Sadhasivam To: andy.gross@linaro.org Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, linus.walleij@linaro.org, koen.kooi@linaro.org, nicolas.dechesne@linaro.org Subject: Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels Message-ID: <20181221023554.GB3233@Mani-XPS-13-9360> References: <20181029094245.7886-1-manivannan.sadhasivam@linaro.org> <20181029094245.7886-8-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181029094245.7886-8-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29, 2018 at 03:12:45PM +0530, Manivannan Sadhasivam wrote: > For all 96Boards, the following standard is used for onboard LEDs. > > green:user1 default-trigger: heartbeat > green:user2 default-trigger: mmc0/disk-activity(onboard-storage) > green:user3 default-trigger: mmc1 (SD-card) > green:user4 default-trigger: none, panic-indicator > yellow:wlan default-trigger: phy0tx > blue:bt default-trigger: hci0-power > > So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is > one of the 96Boards CE platform. > Hello, Any update on this patch? Regards, Mani > Signed-off-by: Manivannan Sadhasivam > Acked-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 46feedf7c989..35f95154316b 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -300,28 +300,28 @@ > compatible = "gpio-leds"; > > led@1 { > - label = "apq8016-sbc:green:user1"; > + label = "green:user1"; > gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > default-state = "off"; > }; > > led@2 { > - label = "apq8016-sbc:green:user2"; > + label = "green:user2"; > gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "mmc0"; > default-state = "off"; > }; > > led@3 { > - label = "apq8016-sbc:green:user3"; > + label = "green:user3"; > gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "mmc1"; > default-state = "off"; > }; > > led@4 { > - label = "apq8016-sbc:green:user4"; > + label = "green:user4"; > gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "none"; > panic-indicator; > @@ -329,14 +329,14 @@ > }; > > led@5 { > - label = "apq8016-sbc:yellow:wlan"; > + label = "yellow:wlan"; > gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "phy0tx"; > default-state = "off"; > }; > > led@6 { > - label = "apq8016-sbc:blue:bt"; > + label = "blue:bt"; > gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "bluetooth-power"; > default-state = "off"; > -- > 2.17.1 >