From: Lee Jones <lee.jones@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/4] tty: serial: samsung: Increase maximum baudrate
Date: Fri, 21 Dec 2018 10:15:53 +0000 [thread overview]
Message-ID: <20181221101553.GI13248@dell> (raw)
In-Reply-To: <20181214113410.22848-4-m.szyprowski@samsung.com>
On Fri, 14 Dec 2018, Marek Szyprowski wrote:
> From: Seung-Woo Kim <sw0312.kim@samsung.com>
>
> This driver can be used to communicate with Bluetooth chip in high-speed
> UART mode, so increase the maximum baudrate to 3Mbps.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> [mszyprow: rephrased commit message]
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 2a49b6d876b8..9fc3559f80d9 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1287,7 +1287,7 @@ static void s3c24xx_serial_set_termios(struct uart_port *port,
> * Ask the core to calculate the divisor for us.
> */
>
> - baud = uart_get_baud_rate(port, termios, old, 0, 115200*8);
> + baud = uart_get_baud_rate(port, termios, old, 0, 3000000);
Does that mean the low speed devices will stop working? It looks like
this should be dynamically configurable based on what device is
connected to it, no?
> quot = s3c24xx_serial_getclk(ourport, baud, &clk, &clk_sel);
> if (baud == 38400 && (port->flags & UPF_SPD_MASK) == UPF_SPD_CUST)
> quot = port->custom_divisor;
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-21 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181214113415eucas1p16dd61a4312d88216cb0d737887c751b7@eucas1p1.samsung.com>
2018-12-14 11:34 ` [PATCH 0/4] Samsung TM2(e): add Bluetooth support (resend) Marek Szyprowski
[not found] ` <CGME20181214113416eucas1p2002adf7b5438c525c34ff3274ceacbd1@eucas1p2.samsung.com>
2018-12-14 11:34 ` [PATCH 1/4] mfd: exynos-lpass: Enable UART module support Marek Szyprowski
2018-12-21 10:13 ` Lee Jones
2018-12-21 10:27 ` Marek Szyprowski
2018-12-21 10:39 ` Lee Jones
[not found] ` <CGME20181221143250eucas1p120b2d4dbcb990c5893e0fa4c6a7dd861@eucas1p1.samsung.com>
2018-12-21 14:32 ` [PATCH v2 " Marek Szyprowski
2018-12-21 14:56 ` Lee Jones
[not found] ` <CGME20181214113417eucas1p2624705c077ae79267082bbf4628951ed@eucas1p2.samsung.com>
2018-12-14 11:34 ` [PATCH 2/4] tty: serial: samsung: Properly set flags in autoCTS mode Marek Szyprowski
[not found] ` <CGME20181214113418eucas1p2bfb6f0d04010e73f6ca35c3a6664b316@eucas1p2.samsung.com>
2018-12-14 11:34 ` [PATCH 3/4] tty: serial: samsung: Increase maximum baudrate Marek Szyprowski
2018-12-21 10:15 ` Lee Jones [this message]
2018-12-21 10:23 ` Marek Szyprowski
2018-12-21 10:34 ` Lee Jones
[not found] ` <CGME20181214113419eucas1p2473172a49bf798ddd95265fa31125d96@eucas1p2.samsung.com>
2018-12-14 11:34 ` [PATCH 4/4] arm64: dts: exynos: Add Bluetooth chip to TM2(e) boards Marek Szyprowski
2018-12-17 21:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221101553.GI13248@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).