From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0536C43387 for ; Sun, 23 Dec 2018 20:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78198217D7 for ; Sun, 23 Dec 2018 20:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725886AbeLWT7l (ORCPT ); Sun, 23 Dec 2018 14:59:41 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48266 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbeLWT7k (ORCPT ); Sun, 23 Dec 2018 14:59:40 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id ED91880897; Sun, 23 Dec 2018 20:59:33 +0100 (CET) Date: Sun, 23 Dec 2018 20:59:37 +0100 From: Pavel Machek To: Tony Lindgren Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Jarkko Nikula , Johan Hovold , Kuninori Morimoto , Marcel Partap , Merlijn Wajer , Michael Scott , NeKit , omerlle@gmail.com, Sebastian Reichel , Peter Ujfalusi , Rob Herring Subject: Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver Message-ID: <20181223195937.GE15237@amd> References: <20181217004450.GW6707@atomide.com> <20181223103315.GA1936@amd> <20181223111059.GB1936@amd> <20181223155147.GI6707@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RpqchZ26BWispMcB" Content-Disposition: inline In-Reply-To: <20181223155147.GI6707@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RpqchZ26BWispMcB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2018-12-23 07:51:47, Tony Lindgren wrote: > * Pavel Machek [181223 11:11]: > > I added some printks to motmdm_probe, and they don't appear to be > > called. I wonder if I'm missing something else in the config? I do > > have serial > >=20 > > root@devuan:/my/ko# ls -al /dev/ttyS0 > > crw-rw---- 1 root dialout 4, 64 Dec 23 11:52 /dev/ttyS0 > >=20 > > but not gsm multiplex: > >=20 > > root@devuan:/my/ko# ls -al /dev/gsm* > > ls: cannot access '/dev/gsm*': No such file or directory >=20 > Hmm with serdev you should not get /dev/ttyS0, so maybe you're missing: >=20 > CONFIG_SERIAL_DEV_BUS=3Dy > CONFIG_SERIAL_DEV_CTRL_TTYPORT=3Dy I had those enabled. I also have CONFIG_SERIAL_OMAP=3Dy CONFIG_SERIAL_OMAP_CONSOLE=3Dy > Probably the Kconfig dependency should be for SERIAL_DEV_CTRL_TTYPORT > instead of SERIAL_DEV_BUS in these patches if that helps. >=20 > Or else you're missing the serdev related dts changes? Thanks for the hints, but dts looks ok, too. We still have uart1: serial@0 { compatible =3D "ti,omap4-uart"; in omap4-l4.dtsi, right? ... I see that CONFIG_SERIAL_OMAP=3Dy and 8250_omap handles same hardware. Let me try disabling CONFIG_SERIAL_OMAP=3Dy. Best regards, Pavel Oh and you may want to apply this: diff --git a/drivers/mfd/motorola-mdm.c b/drivers/mfd/motorola-mdm.c index 2b7c324..2cdc9e8 100644 --- a/drivers/mfd/motorola-mdm.c +++ b/drivers/mfd/motorola-mdm.c @@ -1141,5 +1152,5 @@ module_serdev_device_driver(motmdm_driver); =20 MODULE_ALIAS("platform:motorola-mdm"); MODULE_DESCRIPTION("Motorola Modem TS 27.010 serdev driver"); -MODULE_AUTHOR("Tony Lindgren "); MODULE_LICENSE("GPL v2"); --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --RpqchZ26BWispMcB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwf6SkACgkQMOfwapXb+vLc+QCfdzhtFpsJJdQyVDvOhFUBkjXB UN0An3P/at06sNp/7TZ5GaTB+bYfIYyK =ZCa/ -----END PGP SIGNATURE----- --RpqchZ26BWispMcB--