From: Kangjie Lu <kjlu@umn.edu>
To: kjlu@umn.edu
Cc: pakki001@umn.edu, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] acpi: fix a potential inconsistency caused by double-fetch
Date: Tue, 25 Dec 2018 15:46:33 -0600 [thread overview]
Message-ID: <20181225214633.69973-1-kjlu@umn.edu> (raw)
"user_buf->length" is in user space, and copied in twice. The second
copy is after it passes the security check. If a user program races to
change user_buf->length in user space, the data fetched in the second
copy may invalidate the security check. The fix avoids the double-fetch
issue by using the value passing the security check.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/acpi/custom_method.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index 4451877f83b6..f75f664301b3 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -26,17 +26,16 @@ static ssize_t cm_write(struct file *file, const char __user * user_buf,
static u32 max_size;
static u32 uncopied_bytes;
- struct acpi_table_header table;
acpi_status status;
if (!(*ppos)) {
/* parse the table header to get the table length */
if (count <= sizeof(struct acpi_table_header))
return -EINVAL;
- if (copy_from_user(&table, user_buf,
- sizeof(struct acpi_table_header)))
+ if (get_user(max_size,
+ &(struct acpi_table_header *)user_buf->length))
return -EFAULT;
- uncopied_bytes = max_size = table.length;
+ uncopied_bytes = max_size;
buf = kzalloc(max_size, GFP_KERNEL);
if (!buf)
return -ENOMEM;
@@ -56,6 +55,8 @@ static ssize_t cm_write(struct file *file, const char __user * user_buf,
buf = NULL;
return -EFAULT;
}
+ /* Ensure table length is not changed in the second copy */
+ (struct acpi_table_header *)(buf + (*ppos))->length = max_size;
uncopied_bytes -= count;
*ppos += count;
--
2.17.2 (Apple Git-113)
next reply other threads:[~2018-12-25 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 21:46 Kangjie Lu [this message]
2018-12-25 22:20 ` [PATCH] acpi: fix a potential inconsistency caused by double-fetch kbuild test robot
2018-12-26 0:11 ` kbuild test robot
2019-01-09 8:14 ` [PATCH v2] " Kangjie Lu
2019-01-14 11:15 ` Rafael J. Wysocki
[not found] ` <CAK8KejpGipqLpR93=ZnRze9FU7q5ZhJrGQV33czZwuxqSs0AyQ@mail.gmail.com>
2019-01-15 19:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181225214633.69973-1-kjlu@umn.edu \
--to=kjlu@umn.edu \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).