From: Dave Young <dyoung@redhat.com>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, akpm@linux-foundation.org, bhe@redhat.com,
linux-doc@vger.kernel.org, Kazuhito Hagio <khagio@redhat.com>,
anderson@redhat.com
Subject: Re: [PATCH 0/2 v4] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo
Date: Wed, 26 Dec 2018 11:33:49 +0800 [thread overview]
Message-ID: <20181226033349.GA13822@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20181220054044.30738-1-lijiang@redhat.com>
Add Kazu and Dave in cc
On 12/20/18 at 01:40pm, Lianbo Jiang wrote:
> This patchset did two things:
> a. add a new document for vmcoreinfo
>
> This document lists some variables that export to vmcoreinfo, and briefly
> describles what these variables indicate. It should be instructive for
> many people who do not know the vmcoreinfo, and it also normalizes the
> exported variable as a convention between kernel and use-space.
>
> b. export the value of sme mask to vmcoreinfo
>
> For AMD machine with SME feature, makedumpfile tools need to know whether
> the crash kernel was encrypted or not. If SME is enabled in the first
> kernel, the crash kernel's page table(pgd/pud/pmd/pte) contains the
> memory encryption mask, so need to remove the sme mask to obtain the true
> physical address.
>
> Changes since v1:
> 1. No need to export a kernel-internal mask to userspace, so copy the
> value of sme_me_mask to a local variable 'sme_mask' and write the value
> of sme_mask to vmcoreinfo.
> 2. Add comment for the code.
> 3. Improve the patch log.
> 4. Add the vmcoreinfo documentation.
>
> Changes since v2:
> 1. Improve the vmcoreinfo document, add more descripts for these
> variables exported.
> 2. Fix spelling errors in the document.
>
> Changes since v3:
> 1. Still improve the vmcoreinfo document, and make it become more
> clear and easy to read.
> 2. Move sme_mask comments in the code to the vmcoreinfo document.
> 3. Improve patch log.
>
> Lianbo Jiang (2):
> kdump: add the vmcoreinfo documentation
> kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo
>
> Documentation/kdump/vmcoreinfo.txt | 513 +++++++++++++++++++++++++++++
> arch/x86/kernel/machine_kexec_64.c | 3 +
> 2 files changed, 516 insertions(+)
> create mode 100644 Documentation/kdump/vmcoreinfo.txt
>
> --
> 2.17.1
>
prev parent reply other threads:[~2018-12-26 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 5:40 [PATCH 0/2 v4] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2018-12-20 5:40 ` [PATCH 1/2 v4] kdump: add the vmcoreinfo documentation Lianbo Jiang
2019-01-03 19:28 ` Kazuhito Hagio
2019-01-04 2:28 ` lijiang
2019-01-04 15:31 ` Kazuhito Hagio
2018-12-20 5:40 ` [PATCH 2/2 v4] kdump,vmcoreinfo: Export the value of sme mask to vmcoreinfo Lianbo Jiang
2018-12-26 3:33 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226033349.GA13822@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=kexec@lists.infradead.org \
--cc=khagio@redhat.com \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).