From: Matthew Wilcox <willy@infradead.org>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joe Perches <joe@perches.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction.c: Propagate return value upstream
Date: Wed, 26 Dec 2018 11:11:18 -0800 [thread overview]
Message-ID: <20181226191118.GB20878@bombadil.infradead.org> (raw)
In-Reply-To: <20181226190750.9820-1-pakki001@umn.edu>
On Wed, Dec 26, 2018 at 01:07:49PM -0600, Aditya Pakki wrote:
> {
> + return
> proc_dointvec_minmax(table, write, buffer, length, ppos);
> -
> - return 0;
Don't do this. If you're going to return something, it should be on the same
line as the return statement.
ie:
+ return proc_dointvec_minmax(table, write, buffer, length, ppos);
next prev parent reply other threads:[~2018-12-26 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 19:07 [PATCH] mm: compaction.c: Propagate return value upstream Aditya Pakki
2018-12-26 19:11 ` Matthew Wilcox [this message]
2018-12-26 19:42 Aditya Pakki
2018-12-27 3:50 ` Matthew Wilcox
2018-12-27 16:44 ` Randy Dunlap
2019-01-02 12:24 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226191118.GB20878@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pakki001@umn.edu \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).