From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] soc: qcom: Add AOSS QMP genpd provider
Date: Wed, 26 Dec 2018 12:30:33 -0800 [thread overview]
Message-ID: <20181226203032.GF9704@minitux> (raw)
In-Reply-To: <dfd0096c-d1f1-da0e-7c4c-3da916d521dc@codeaurora.org>
On Mon 26 Nov 19:31 PST 2018, Sai Prakash Ranjan wrote:
> Hi Bjorn,
>
Thanks for your review Sai!
> On 11/12/2018 1:35 PM, Bjorn Andersson wrote:
[..]
> > +static int qmp_pd_clock_toggle(struct qmp_pd *res, bool enable)
> > +{
> > + char buf[96];
> > + size_t n;
> > +
> > + n = snprintf(buf, sizeof(buf), "{class: clock, res: %s, val: %d}",
> > + res->name, !!enable);
> > + return qmp_send(res->qmp, buf, n);
> > +}
> > +
>
> I was trying to get QDSS working with these patches and found one issue
> in qmp_send of qmp_pd_clock_toggle.
>
> The third return value should be sizeof(buf) instead of n because n just
> returns len as 33 and the below check in qmp send will always fail and
> trigger WARN_ON's.
>
> if (WARN_ON(len % sizeof(u32))) {
> dev_err(qmp->dev, "message not 32-bit aligned\n");
> return -EINVAL;
> }
>
> Also I observed that multiple "ucore will not ack channel" messages with
> len being returned n instead of buf size.
>
I must have been "lucky" when I did my final pass of cleanups and
retests, thanks for spotting this!
> One more thing is do we really require *WARN_ON and dev_err* both because it
> just spams the kernel logs, I think dev_err message is clear
> enough to be able to understand the error condition.
>
No, that's just unnecessary.
Regards,
Bjorn
next prev parent reply other threads:[~2018-12-26 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 8:05 [PATCH 0/3] Qualcomm AOSS QMP side channel binding and driver Bjorn Andersson
2018-11-12 8:05 ` [PATCH 1/3] dt-bindings: soc: qcom: Add AOSS QMP binding Bjorn Andersson
2018-12-03 23:51 ` Rob Herring
2018-12-10 23:56 ` Doug Anderson
2018-11-12 8:05 ` [PATCH 2/3] soc: qcom: Add AOSS QMP communication driver Bjorn Andersson
[not found] ` <ce0d4d55-464c-1502-9dc1-b3a495c86aee@codeaurora.org>
2018-12-26 20:28 ` Bjorn Andersson
2019-01-03 17:48 ` Arun Kumar Neelakantam
2018-11-12 8:05 ` [PATCH 3/3] soc: qcom: Add AOSS QMP genpd provider Bjorn Andersson
2018-11-27 3:31 ` Sai Prakash Ranjan
2018-12-26 20:30 ` Bjorn Andersson [this message]
2018-11-27 10:50 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226203032.GF9704@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).