LKML Archive on
 help / color / Atom feed
From: Jiri Olsa <>
To: Arnaldo Carvalho de Melo <>
Cc: lkml <>,
	Ingo Molnar <>,
	Namhyung Kim <>,
	Alexander Shishkin <>,
	Peter Zijlstra <>,
	Joe Mario <>
Subject: [PATCH 1/2] perf c2c: Change the default coalesce setup
Date: Fri, 28 Dec 2018 11:18:19 +0100
Message-ID: <> (raw)

Joe suggested to have the coalesce default set just to 'iaddr',
because it's easier to read on the (default) c2c report run.

By removing pid from -c option, the c2c report will group all
the relevant pids under instruction address bucket. User can
always run -c pid,iaddr for more grained output on particular

Suggested-by: Joe Mario <>
Signed-off-by: Jiri Olsa <>
 tools/perf/builtin-c2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 686fb60a8e11..321687f8f373 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
 	struct hist_entry	he;
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
 struct perf_c2c {
 	struct perf_tool	tool;

             reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 10:18 Jiri Olsa [this message]
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39   ` Arnaldo Carvalho de Melo
2019-01-03 13:19   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone