From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines
Date: Fri, 28 Dec 2018 09:39:18 -0300 [thread overview]
Message-ID: <20181228123918.GE25753@kernel.org> (raw)
In-Reply-To: <20181228101820.28010-2-jolsa@kernel.org>
Em Fri, Dec 28, 2018 at 11:18:20AM +0100, Jiri Olsa escreveu:
> The cachelines being reported go down to 0.05%. hat makes for very
> long output files. Raising that to 0.1%. The user can always specify
> --show-all if they want all the cachelines.
Thanks, applied.
- Arnaldo
> Suggested-by: Joe Mario <jmario@redhat.com>
> Link: http://lkml.kernel.org/n/tip-uwxpd36jutygit56mycanwma@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/builtin-c2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 321687f8f373..30584cb44fb7 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -1878,7 +1878,7 @@ static int c2c_hists__reinit(struct c2c_hists *c2c_hists,
> return hpp_list__parse(&c2c_hists->list, output, sort);
> }
>
> -#define DISPLAY_LINE_LIMIT 0.0005
> +#define DISPLAY_LINE_LIMIT 0.001
>
> static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
> {
> --
> 2.17.2
--
- Arnaldo
next prev parent reply other threads:[~2018-12-28 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo [this message]
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228123918.GE25753@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).