From: Andrew Morton <email@example.com> To: Christian Brauner <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v5 RESEND] signal: add pidfd_send_signal() syscall Date: Fri, 28 Dec 2018 15:20:12 -0800 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On Fri, 28 Dec 2018 23:48:53 +0100 Christian Brauner <firstname.lastname@example.org> wrote: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been a push to address this problem . > > This patch uses file descriptors (fd) from proc/<pid> as stable handles on > struct pid. Even if a pid is recycled the handle will not change. The fd > can be used to send signals to the process it refers to. > Thus, the new syscall pidfd_send_signal() is introduced to solve this > problem. Instead of pids it operates on process fds (pidfd). I can't see a description of what happens when the target process has exited. Is the task_struct pinned by the fd? Does the entire procfs directory remain visible? Just one entry within it? Does the pid remain reserved? Do attempts to signal that fd return errors? etcetera. These behaviors should be described in the changelog and manipulate please. The code in signal.c appears to be compiled in even when CONFIG_PROC_FS=y. Can we add the appropriate ifdefs and an entry in sys_ni.c? A selftest in toole/testing/selftests would be nice. And it will be helpful to architecture maintainers as they wire this up. The feature doesn't have its own Kconfig setting. Perhaps it should? It should presumably depend on PROC_FS. I must say that I dislike the linkage to procfs. procfs is a high-level thing which is manipulated using syscalls. To turn around and make a syscall dependent upon the presence of procfs seems just ... wrong. Is there a cleaner way of obtaining the fd? Another syscall perhaps. This fd-for-a-process sounds like a handy thing and people may well think up other uses for it in the future, probably unrelated to signals. Are the code and the interface designed to permit such future applications? I guess "no" - it presently assumes that anything which is written to that fd is a signal. Perhaps there should be a tag at the start of the message (which is what it is) which identifies the message's type? Now I think about it, why a new syscall? This thing is looking rather like an ioctl?
next prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-28 22:48 Christian Brauner 2018-12-28 23:20 ` Andrew Morton [this message] 2018-12-28 23:37 ` Christian Brauner
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git