From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Willy Tarreau <w@1wt.eu>
Cc: mingo@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools headers: move the nolibc header from rcutorture to tools/include/nolibc/
Date: Sat, 29 Dec 2018 10:25:08 -0800 [thread overview]
Message-ID: <20181229182508.GJ4170@linux.ibm.com> (raw)
In-Reply-To: <20181229180453.15889-1-w@1wt.eu>
On Sat, Dec 29, 2018 at 07:04:53PM +0100, Willy Tarreau wrote:
> As suggested by Ingo, this header file might benefit other tools than
> just rcutorture. For now it's quite limited, but is easy to extend, so
> exposing it into tools/include/nolibc/ will make it much easier to
> adopt by other tools.
>
> The mkinitrd.sh script in rcutorture was updated to use this new location.
>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
Thank you, Willy! I have queued all four of these. Should there
be a MAINTAINERS file entry for the new include/nolibc home for this
library code?
Thanx, Paul
> ---
> tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h | 0
> tools/testing/selftests/rcutorture/bin/mkinitrd.sh | 4 ++--
> 2 files changed, 2 insertions(+), 2 deletions(-)
> rename tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h (100%)
>
> diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/include/nolibc/nolibc.h
> similarity index 100%
> rename from tools/testing/selftests/rcutorture/bin/nolibc.h
> rename to tools/include/nolibc/nolibc.h
> diff --git a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> index da29839..d93bca1 100755
> --- a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> +++ b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> @@ -124,8 +124,8 @@ if echo -e "#if __x86_64__||__i386__||__i486__||__i586__||__i686__" \
> | grep -q '^yes'; then
> # architecture supported by nolibc
> ${CROSS_COMPILE}gcc -fno-asynchronous-unwind-tables -fno-ident \
> - -nostdlib -include ../bin/nolibc.h -lgcc -s -static -Os \
> - -o init init.c
> + -nostdlib -include ../../../../include/nolibc/nolibc.h \
> + -lgcc -s -static -Os -o init init.c
> else
> ${CROSS_COMPILE}gcc -s -static -Os -o init init.c
> fi
> --
> 2.9.0
>
next prev parent reply other threads:[~2018-12-29 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 18:04 [PATCH] tools headers: move the nolibc header from rcutorture to tools/include/nolibc/ Willy Tarreau
2018-12-29 18:25 ` Paul E. McKenney [this message]
2018-12-29 18:30 ` Willy Tarreau
2018-12-29 19:55 ` Paul E. McKenney
2018-12-29 20:00 ` Willy Tarreau
2018-12-30 11:25 ` Ingo Molnar
2018-12-30 11:38 ` Willy Tarreau
2018-12-30 11:50 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229182508.GJ4170@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).