From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: mingo@kernel.org, paulmck@linux.vnet.ibm.com,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and alignment
Date: Sat, 29 Dec 2018 12:30:33 -1000 [thread overview]
Message-ID: <20181229223033.q4gx4cn7ci6scysr@gmail.com> (raw)
In-Reply-To: <20181229180218.15798-3-w@1wt.eu>
[-- Attachment #1: Type: text/plain, Size: 3363 bytes --]
On Sat, Dec 29, 2018 at 07:02:17PM +0100, Willy Tarreau wrote:
> A few macros had their rightmost backslash misaligned, and the pollfd
> struct definition resisted the previous code reindent. Nothing else
> changed.
>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>
> ---
> tools/testing/selftests/rcutorture/bin/nolibc.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/testing/selftests/rcutorture/bin/nolibc.h
> index 30bd27b..985364c 100644
> --- a/tools/testing/selftests/rcutorture/bin/nolibc.h
> +++ b/tools/testing/selftests/rcutorture/bin/nolibc.h
> @@ -81,9 +81,9 @@ typedef signed long time_t;
>
> /* for poll() */
> struct pollfd {
> - int fd;
> - short int events;
> - short int revents;
> + int fd;
> + short int events;
> + short int revents;
> };
>
> /* for select() */
> @@ -239,7 +239,7 @@ struct stat {
> "syscall\n" \
> : "=a" (_ret) \
> : "0"(_num) \
> - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> ); \
> _ret; \
> })
> @@ -255,7 +255,7 @@ struct stat {
> : "=a" (_ret) \
> : "r"(_arg1), \
> "0"(_num) \
> - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> ); \
> _ret; \
> })
> @@ -272,7 +272,7 @@ struct stat {
> : "=a" (_ret) \
> : "r"(_arg1), "r"(_arg2), \
> "0"(_num) \
> - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> ); \
> _ret; \
> })
> @@ -290,7 +290,7 @@ struct stat {
> : "=a" (_ret) \
> : "r"(_arg1), "r"(_arg2), "r"(_arg3), \
> "0"(_num) \
> - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> ); \
> _ret; \
> })
> --
> 2.9.0
>
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-29 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 18:02 [PATCH-v2 0/3] rcutorture: minor nolibc fixes Willy Tarreau
2018-12-29 18:02 ` [PATCH 1/4] rcutorture/nolibc: fix the clobbered registers in the MIPS syscall definition Willy Tarreau
2018-12-29 18:02 ` [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and alignment Willy Tarreau
2018-12-29 22:30 ` Joey Pabalinas [this message]
2018-12-31 19:43 ` Paul E. McKenney
2018-12-29 18:02 ` [PATCH 3/4] rcutorture/nolibc: add a bit of documentation to explain how to use nolibc Willy Tarreau
2018-12-29 22:33 ` Joey Pabalinas
2018-12-30 7:08 ` Willy Tarreau
2018-12-30 7:40 ` Joey Pabalinas
2018-12-31 20:08 ` Paul E. McKenney
2018-12-31 23:56 ` Willy Tarreau
2019-01-01 0:21 ` Joey Pabalinas
2019-01-01 17:57 ` Paul E. McKenney
2018-12-29 22:35 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229223033.q4gx4cn7ci6scysr@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rdunlap@infradead.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).