linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: devel@driverdev.osuosl.org, Kees Cook <keescook@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, pakki001@umn.edu,
	Aymen Qader <qader.aymen@gmail.com>
Subject: Re: [PATCH] rts5208: fix a missing check of ms read
Date: Wed, 2 Jan 2019 14:30:47 +0300	[thread overview]
Message-ID: <20190102113047.GL3781@kadam> (raw)
In-Reply-To: <20181220200002.29685-1-kjlu@umn.edu>

On Thu, Dec 20, 2018 at 02:00:01PM -0600, Kangjie Lu wrote:
> When ms_read_extra_data fails, the data read in "extra" buffer is
> just incorrect and thus should be used. However, "extra" is used
> in multiple places no matter ms_read_extra_data() fails or not.
> The fix checks the status of ms_read_extra_data() and returns with
> an error code upon its failure.
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


      parent reply	other threads:[~2019-01-02 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 20:00 [PATCH] rts5208: fix a missing check of ms read Kangjie Lu
2018-12-20 20:14 ` Dan Carpenter
2019-01-02 11:30 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102113047.GL3781@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pakki001@umn.edu \
    --cc=qader.aymen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).