* [PATCH v5 01/11] ACPI / LPSS: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: " Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")', it is possible to build ACPI without any PCI support.
This code depends on PCI. Compile only when PCI is present.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/Makefile | 3 ++-
drivers/acpi/internal.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 7c6afc111d76..bb857421c2e8 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -41,7 +41,8 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-y += acpi_lpss.o acpi_apd.o
+acpi-$(CONFIG_PCI) += acpi_lpss.o
+acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 7e6952edb5b0..6a9e1fb8913a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
+#ifdef CONFIG_PCI
void acpi_lpss_init(void);
+#else
+static inline void acpi_lpss_init(void) {}
+#endif
void acpi_apd_init(void);
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-07 11:12 ` Rafael J. Wysocki
2019-01-02 18:10 ` [PATCH v5 03/11] vga-switcheroo: make " Sinan Kaya
` (8 subsequent siblings)
10 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. PATA_ACPI is a PCI device driver but the PCI
dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: " Sinan Kaya
@ 2019-01-07 11:12 ` Rafael J. Wysocki
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
0 siblings, 1 reply; 37+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:12 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. PATA_ACPI is a PCI device driver but the PCI
> dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 4ca7a6b4eaae..8218db17ebdb 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>
> config PATA_ACPI
> tristate "ACPI firmware driver for PATA"
> - depends on ATA_ACPI && ATA_BMDMA
> + depends on ATA_ACPI && ATA_BMDMA && PCI
> help
> This option enables an ACPI method driver which drives
> motherboard PATA controller interfaces through the ACPI
> --
Any objections against this one from anyone?
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 03/11] vga-switcheroo: make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 04/11] platform/x86: intel_ips: " Sinan Kaya
` (7 subsequent siblings)
10 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Sean Paul,
open list:DRM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* [PATCH v5 04/11] platform/x86: intel_ips: make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (2 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 03/11] vga-switcheroo: make " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-04 14:13 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
` (6 subsequent siblings)
10 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Ipss driver is a PCI device driver but this has
not been mentioned anywhere in Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 04/11] platform/x86: intel_ips: make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 04/11] platform/x86: intel_ips: " Sinan Kaya
@ 2019-01-04 14:13 ` Andy Shevchenko
0 siblings, 0 replies; 37+ messages in thread
From: Andy Shevchenko @ 2019-01-04 14:13 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, ACPI Devel Maling List, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. Ipss driver is a PCI device driver but this has
> not been mentioned anywhere in Kconfig.
>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e3b62c2ee8d1..b36ea14b41ad 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
>
> config INTEL_IPS
> tristate "Intel Intelligent Power Sharing"
> - depends on ACPI
> + depends on ACPI && PCI
> ---help---
> Intel Calpella platforms support dynamic power sharing between the
> CPU and GPU, maximizing performance in a given TDP. This driver,
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (3 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 04/11] platform/x86: intel_ips: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-04 14:20 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
` (5 subsequent siblings)
10 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Code relies on PCI for execution. Specify this
in the Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..7afb96cb1cd6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
- depends on ACPI
+ depends on ACPI && PCI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
@ 2019-01-04 14:20 ` Andy Shevchenko
2019-01-04 15:07 ` Sinan Kaya
0 siblings, 1 reply; 37+ messages in thread
From: Andy Shevchenko @ 2019-01-04 14:20 UTC (permalink / raw)
To: Sinan Kaya, Kuppuswamy Sathyanarayanan, Krogerus, Heikki
Cc: linux-next, ACPI Devel Maling List, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. Code relies on PCI for execution. Specify this
> in the Kconfig.
>
Unfortunately, this is not how it should be fixed.
First of all, we (Heikki, Sathya, me — all in Cc list) that this
driver should be refactored and unified with intel_scu_ipc.
Then, it has two drivers inside and PCI is just a glue for it which is
optional. Thus, needs to be split accordingly.
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index b36ea14b41ad..7afb96cb1cd6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
>
> config INTEL_PMC_IPC
> tristate "Intel PMC IPC Driver"
> - depends on ACPI
> + depends on ACPI && PCI
> ---help---
> This driver provides support for PMC control on some Intel platforms.
> The PMC is an ARC processor which defines IPC commands for communication
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
2019-01-04 14:20 ` Andy Shevchenko
@ 2019-01-04 15:07 ` Sinan Kaya
0 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-04 15:07 UTC (permalink / raw)
To: Andy Shevchenko, Kuppuswamy Sathyanarayanan, Krogerus, Heikki
Cc: linux-next, ACPI Devel Maling List, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On 1/4/2019 9:20 AM, Andy Shevchenko wrote:
> Unfortunately, this is not how it should be fixed.
>
> First of all, we (Heikki, Sathya, me — all in Cc list) that this
> driver should be refactored and unified with intel_scu_ipc.
> Then, it has two drivers inside and PCI is just a glue for it which is
> optional. Thus, needs to be split accordingly.
OK. Two questions:
1. How should I change this now?
2. Can you change the Kconfig accordingly after you merge the two drivers?
I'm focused on the build failure at this moment.
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (4 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:45 ` Lukas Wunner
2019-01-04 14:12 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
` (4 subsequent siblings)
10 siblings, 2 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver depends on the PCI infrastructure but
the dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..89f4b86244a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
@ 2019-01-02 18:45 ` Lukas Wunner
2019-01-04 14:12 ` Andy Shevchenko
1 sibling, 0 replies; 37+ messages in thread
From: Lukas Wunner @ 2019-01-02 18:45 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
On Wed, Jan 02, 2019 at 06:10:33PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver depends on the PCI infrastructure but
> the dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7afb96cb1cd6..89f4b86244a7 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> config APPLE_GMUX
> tristate "Apple Gmux Driver"
> depends on ACPI
> + depends on PCI
> depends on PNP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> --
> 2.19.0
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-02 18:45 ` Lukas Wunner
@ 2019-01-04 14:12 ` Andy Shevchenko
2019-01-04 14:20 ` Andy Shevchenko
1 sibling, 1 reply; 37+ messages in thread
From: Andy Shevchenko @ 2019-01-04 14:12 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, ACPI Devel Maling List, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver depends on the PCI infrastructure but
> the dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7afb96cb1cd6..89f4b86244a7 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> config APPLE_GMUX
> tristate "Apple Gmux Driver"
> depends on ACPI
> + depends on PCI
Can you stick with the same pattern you have used for the rest in this series?
I.e.
depends on ACPI && PCI
> depends on PNP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
2019-01-04 14:12 ` Andy Shevchenko
@ 2019-01-04 14:20 ` Andy Shevchenko
0 siblings, 0 replies; 37+ messages in thread
From: Andy Shevchenko @ 2019-01-04 14:20 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, ACPI Devel Maling List, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Fri, Jan 4, 2019 at 4:12 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote:
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This driver depends on the PCI infrastructure but
> > the dependency has not been explicitly called out.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 7afb96cb1cd6..89f4b86244a7 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> > config APPLE_GMUX
> > tristate "Apple Gmux Driver"
>
> > depends on ACPI
> > + depends on PCI
>
> Can you stick with the same pattern you have used for the rest in this series?
> I.e.
> depends on ACPI && PCI
After satisfying it
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
>
> > depends on PNP
> > depends on BACKLIGHT_CLASS_DEVICE
> > depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> > --
> > 2.19.0
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (5 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
` (3 subsequent siblings)
10 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Need CONFIG_PCI to be set in order to be able to use
this driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (6 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-03 12:33 ` Mark Brown
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: " Sinan Kaya
` (2 subsequent siblings)
10 siblings, 2 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
IOSF_MBI driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2019-01-02 20:33 ` Pierre-Louis Bossart
2019-01-02 22:01 ` Rafael J. Wysocki
2019-01-02 22:09 ` Sinan Kaya
2019-01-03 12:33 ` Mark Brown
1 sibling, 2 replies; 37+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-02 20:33 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: moderated list:INTEL ASoC DRIVERS, Takashi Iwai, Jie Yang,
Liam Girdwood, linux-acpi, Mark Brown, open list
[-- Attachment #1: Type: text/plain, Size: 3648 bytes --]
I have three opens with this ACPI/PCI change
1. the baseline change fails on my cross-compilation checks, see below
the result of the attached script (simplification of the one I use to
avoid 0day reports).
2. there are different patterns to express the dependency on PCI e.g.
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
- select IOSF_MBI if X86
+ select IOSF_MBI if (X86 && PCI)
but
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
IOSF is only needed for Baytrail-CR detection, and the code will compile
fine without it, so maybe it'd be a better model if you used the
following diff?
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..68af0ea5c96c 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
- select IOSF_MBI
+ select IOSF_MBI if PCI
3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
ACPI, so we expose drivers that can be selected but fail on probe since
there are no machine drivers. I am not sure if we want to be strict and
only expose meaningful configurations, or allow for more compilations
tests and corner cases?
-Pierre
cross-compilation issue:
git checkout next-20190102
make CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/ia64-linux/bin/ia64-linux-
--jobs=16 allmodconfig ARCH=ia64
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
YACC scripts/kconfig/zconf.tab.c
LEX scripts/kconfig/zconf.lex.c
HOSTCC scripts/kconfig/confdata.o
HOSTCC scripts/kconfig/expr.o
HOSTCC scripts/kconfig/symbol.o
YACC scripts/kconfig/zconf.tab.h
HOSTCC scripts/kconfig/preprocess.o
HOSTCC scripts/kconfig/zconf.tab.o
HOSTCC scripts/kconfig/zconf.lex.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf --allmodconfig Kconfig
arch/ia64/Kconfig:128:error: recursive dependency detected!
arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
HIBERNATION
kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
init/Kconfig:250: symbol SWAP depends on BLOCK
block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
fs/Kconfig:227: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
IA64_HP_SIM
arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice <choice>
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
[-- Attachment #2: cross-check._sh --]
[-- Type: text/plain, Size: 1075 bytes --]
#!/bin/bash
set -e
test_fast() {
PLATFORM="$1"
make mrproper
../make.cross allmodconfig ARCH=$PLATFORM
../make.cross olddefconfig ARCH=$PLATFORM
../make.cross ARCH=$PLATFORM modules_prepare
}
test_compile() {
PLATFORM="$1"
make mrproper
make defconfig ARCH=$PLATFORM
echo "modules first"
../make.cross ARCH=$PLATFORM
if [ "$PLATFORM" = "x86_64" ]; then
../make.cross bindeb-pkg ARCH=$PLATFORM
fi
echo "all yes second"
perl -pi.bak -e 's/=m/=y/g' .config
../make.cross olddefconfig ARCH=$PLATFORM
../make.cross ARCH=$PLATFORM
if [ "$PLATFORM" = "x86_64" ]; then
../make.cross bindeb-pkg ARCH=$PLATFORM
fi
}
test_platform() {
PLATFORM="$1"
test_fast $PLATFORM
# test_compile $PLATFORM
}
test_platform x86_64
test_platform i386
test_platform ia64
test_platform arm
test_platform arm64
test_platform sh
test_platform mips
test_platform s390
test_platform openrisc
test_platform sparc
test_platform sparc64
test_platform m68k
echo "X-compilation check PASS"
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
@ 2019-01-02 22:01 ` Rafael J. Wysocki
2019-01-02 22:09 ` Sinan Kaya
1 sibling, 0 replies; 37+ messages in thread
From: Rafael J. Wysocki @ 2019-01-02 22:01 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Sinan Kaya, Linux-Next Mailing List,
moderated list:INTEL ASoC DRIVERS, Takashi Iwai, Jie Yang,
Liam Girdwood, ACPI Devel Maling List, Mark Brown, open list
On Wed, Jan 2, 2019 at 9:33 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> I have three opens with this ACPI/PCI change
>
> 1. the baseline change fails on my cross-compilation checks, see below
> the result of the attached script (simplification of the one I use to
> avoid 0day reports).
What baseline change?
That failure is not related to PCI if I'm not missing anything.
> 2. there are different patterns to express the dependency on PCI e.g.
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> depends on MMC_SDHCI && ACPI
> - select IOSF_MBI if X86
> + select IOSF_MBI if (X86 && PCI)
>
> but
>
> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> default ACPI
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
>
> IOSF is only needed for Baytrail-CR detection, and the code will compile
> fine without it, so maybe it'd be a better model if you used the
> following diff?
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 2fd1b61e8331..68af0ea5c96c 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
> - select IOSF_MBI
> + select IOSF_MBI if PCI
Well, does it actually make sense to ever set
SND_SST_ATOM_HIFI2_PLATFORM_ACPI without PCI?
> 3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
> on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
> ACPI, so we expose drivers that can be selected but fail on probe since
> there are no machine drivers. I am not sure if we want to be strict and
> only expose meaningful configurations, or allow for more compilations
> tests and corner cases?
I would only expose meaningful configurations to start with and then
*maybe* relax that going forward as long as the benefit is worth it.
Cheers,
Rafael
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-02 22:01 ` Rafael J. Wysocki
@ 2019-01-02 22:09 ` Sinan Kaya
2019-01-02 22:50 ` Pierre-Louis Bossart
1 sibling, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 22:09 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Linux Next Mailing List, moderated list:INTEL ASoC DRIVERS,
Takashi Iwai, Jie Yang, Liam Girdwood, ACPI Devel Mailing List,
Mark Brown, open list
On Wed, Jan 2, 2019 at 8:33 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> I have three opens with this ACPI/PCI change
>
> 1. the baseline change fails on my cross-compilation checks, see below
> the result of the attached script (simplification of the one I use to
> avoid 0day reports).
>
This is pointing to a kconfig issue on ia64 arch.
arch/ia64/Kconfig:128:error: recursive dependency detected!
arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
IA64_HP_SIM is both a choice and is selected.
I did allyesconfig and disabled PCI afterwards to find all the issues
on this patchset.
> 2. there are different patterns to express the dependency on PCI e.g.
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> depends on MMC_SDHCI && ACPI
> - select IOSF_MBI if X86
> + select IOSF_MBI if (X86 && PCI)
>
> but
>
> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> default ACPI
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
>
I matched depends line to
depends on X86 && ACPI && PCI
for MMC_SDHCI_ACPI per feedback from Rafael on V5. This should resolve
the inconsistency.
> IOSF is only needed for Baytrail-CR detection, and the code will compile
> fine without it, so maybe it'd be a better model if you used the
> following diff?
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 2fd1b61e8331..68af0ea5c96c 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
> - select IOSF_MBI
> + select IOSF_MBI if PCI
>
> 3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
> on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
> ACPI, so we expose drivers that can be selected but fail on probe since
> there are no machine drivers. I am not sure if we want to be strict and
> only expose meaningful configurations, or allow for more compilations
> tests and corner cases?
Hopefully, v5 resolves this too with
depends on X86 && ACPI && PCI
Let me know otherwise.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 22:09 ` Sinan Kaya
@ 2019-01-02 22:50 ` Pierre-Louis Bossart
2019-01-02 22:58 ` Sinan Kaya
0 siblings, 1 reply; 37+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-02 22:50 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux Next Mailing List, moderated list:INTEL ASoC DRIVERS,
Takashi Iwai, Jie Yang, Liam Girdwood, ACPI Devel Mailing List,
Mark Brown, open list
> This is pointing to a kconfig issue on ia64 arch.
>
> arch/ia64/Kconfig:128:error: recursive dependency detected!
> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
>
> IA64_HP_SIM is both a choice and is selected.
>
> I did allyesconfig and disabled PCI afterwards to find all the issues
> on this patchset.
Are you saying there's a newer series that fixes this issue for both
allyesconfig and allmodconfig?
if yes, then we're good.
>
>> 2. there are different patterns to express the dependency on PCI e.g.
>>
>> config MMC_SDHCI_ACPI
>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>> depends on MMC_SDHCI && ACPI
>> - select IOSF_MBI if X86
>> + select IOSF_MBI if (X86 && PCI)
>>
>> but
>>
>> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
>> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
>> default ACPI
>> - depends on X86 && ACPI
>> + depends on X86 && ACPI && PCI
>> select SND_SST_IPC_ACPI
>> select SND_SST_ATOM_HIFI2_PLATFORM
>> select SND_SOC_ACPI_INTEL_MATCH
>>
> I matched depends line to
>
> depends on X86 && ACPI && PCI
>
> for MMC_SDHCI_ACPI per feedback from Rafael on V5. This should resolve
> the inconsistency.
ok, I didn't see the delta
>
>
>> IOSF is only needed for Baytrail-CR detection, and the code will compile
>> fine without it, so maybe it'd be a better model if you used the
>> following diff?
>>
>> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
>> index 2fd1b61e8331..68af0ea5c96c 100644
>> --- a/sound/soc/intel/Kconfig
>> +++ b/sound/soc/intel/Kconfig
>> @@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
>> select SND_SST_IPC_ACPI
>> select SND_SST_ATOM_HIFI2_PLATFORM
>> select SND_SOC_ACPI_INTEL_MATCH
>> - select IOSF_MBI
>> + select IOSF_MBI if PCI
>>
>> 3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
>> on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
>> ACPI, so we expose drivers that can be selected but fail on probe since
>> there are no machine drivers. I am not sure if we want to be strict and
>> only expose meaningful configurations, or allow for more compilations
>> tests and corner cases?
> Hopefully, v5 resolves this too with
>
> depends on X86 && ACPI && PCI
>
> Let me know otherwise.
it doesn't but that's not a good enough reason to lay on the tracks.
I'll follow-up with a cleanup for the Intel audio parts when this series
is merged. The PCI dependency could be moved to the top-level since it's
pretty much required for all platforms except for compilation tests, and
there are multiple dependencies that repeated for no good reason, so FWIW
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 22:50 ` Pierre-Louis Bossart
@ 2019-01-02 22:58 ` Sinan Kaya
2019-01-02 23:50 ` Pierre-Louis Bossart
0 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 22:58 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Linux Next Mailing List, moderated list:INTEL ASoC DRIVERS,
Takashi Iwai, Jie Yang, Liam Girdwood, ACPI Devel Mailing List,
Mark Brown, open list
On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> > This is pointing to a kconfig issue on ia64 arch.
> >
> > arch/ia64/Kconfig:128:error: recursive dependency detected!
> > arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> > arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
> >
> > IA64_HP_SIM is both a choice and is selected.
> >
> > I did allyesconfig and disabled PCI afterwards to find all the issues
> > on this patchset.
>
> Are you saying there's a newer series that fixes this issue for both
> allyesconfig and allmodconfig?
>
> if yes, then we're good.
No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
used allyesconfig to find out all compilation issues on x86 arch to
come up with this patchset.
>
> >
> >> 2. there are different patterns to express the dependency on PCI e.g.
> >>
> >> config MMC_SDHCI_ACPI
> >> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> >> depends on MMC_SDHCI && ACPI
> >> - select IOSF_MBI if X86
> >> + select IOSF_MBI if (X86 && PCI)
> >>
> >> but
> >>
> >> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> >> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> >> default ACPI
> >> - depends on X86 && ACPI
> >> + depends on X86 && ACPI && PCI
> >> select SND_SST_IPC_ACPI
> >> select SND_SST_ATOM_HIFI2_PLATFORM
> >> select SND_SOC_ACPI_INTEL_MATCH
> >>
> > I matched depends line to
> >
> > depends on X86 && ACPI && PCI
> >
> > for MMC_SDHCI_ACPI per feedback from Rafael on V5. This should resolve
> > the inconsistency.
> ok, I didn't see the delta
> >
> >
> >> IOSF is only needed for Baytrail-CR detection, and the code will compile
> >> fine without it, so maybe it'd be a better model if you used the
> >> following diff?
> >>
> >> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> >> index 2fd1b61e8331..68af0ea5c96c 100644
> >> --- a/sound/soc/intel/Kconfig
> >> +++ b/sound/soc/intel/Kconfig
> >> @@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> >> select SND_SST_IPC_ACPI
> >> select SND_SST_ATOM_HIFI2_PLATFORM
> >> select SND_SOC_ACPI_INTEL_MATCH
> >> - select IOSF_MBI
> >> + select IOSF_MBI if PCI
> >>
> >> 3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
> >> on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
> >> ACPI, so we expose drivers that can be selected but fail on probe since
> >> there are no machine drivers. I am not sure if we want to be strict and
> >> only expose meaningful configurations, or allow for more compilations
> >> tests and corner cases?
> > Hopefully, v5 resolves this too with
> >
> > depends on X86 && ACPI && PCI
> >
> > Let me know otherwise.
>
> it doesn't but that's not a good enough reason to lay on the tracks.
> I'll follow-up with a cleanup for the Intel audio parts when this series
> is merged. The PCI dependency could be moved to the top-level since it's
> pretty much required for all platforms except for compilation tests, and
> there are multiple dependencies that repeated for no good reason, so FWIW
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 22:58 ` Sinan Kaya
@ 2019-01-02 23:50 ` Pierre-Louis Bossart
2019-01-03 3:28 ` Sinan Kaya
2019-01-03 4:08 ` Chandan Rajendra
0 siblings, 2 replies; 37+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-02 23:50 UTC (permalink / raw)
To: Sinan Kaya
Cc: moderated list:INTEL ASoC DRIVERS, Mark Brown, Jie Yang,
Takashi Iwai, open list, Liam Girdwood, ACPI Devel Mailing List,
Linux Next Mailing List, Chandan Rajendra
On 1/2/19 4:58 PM, Sinan Kaya wrote:
> On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>>> This is pointing to a kconfig issue on ia64 arch.
>>>
>>> arch/ia64/Kconfig:128:error: recursive dependency detected!
>>> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
>>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
>>>
>>> IA64_HP_SIM is both a choice and is selected.
>>>
>>> I did allyesconfig and disabled PCI afterwards to find all the issues
>>> on this patchset.
>> Are you saying there's a newer series that fixes this issue for both
>> allyesconfig and allmodconfig?
>>
>> if yes, then we're good.
>
> No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
> used allyesconfig to find out all compilation issues on x86 arch to
> come up with this patchset.
Nothing makes me cringe more than "somebody else's job" statements. In
this case, there is obviously a correlation with your ACPI changes since
the circular dependency happens because of the ACPI symbol.
arch/ia64/Kconfig:126:error: recursive dependency detected!
arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
HIBERNATION
kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
init/Kconfig:250: symbol SWAP depends on BLOCK
block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
<<<< LOOK HERE
drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
IA64_HP_SIM
arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
At any rate, a 3 mn git bisect tells me the circular dependency is
exposed by this change:
f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Date: Sat Dec 8 12:21:38 2018 +0530
fscrypt: remove filesystem specific build config option
In order to have a common code base for fscrypt "post read" processing
for all filesystems which support encryption, this commit removes
filesystem specific build config option (e.g.
CONFIG_EXT4_FS_ENCRYPTION)
and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
value affects all the filesystems making use of fscrypt.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-Pierre
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 23:50 ` Pierre-Louis Bossart
@ 2019-01-03 3:28 ` Sinan Kaya
2019-01-03 4:08 ` Chandan Rajendra
1 sibling, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-03 3:28 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: moderated list:INTEL ASoC DRIVERS, Mark Brown, Jie Yang,
Takashi Iwai, open list, Liam Girdwood, ACPI Devel Mailing List,
Linux Next Mailing List, Chandan Rajendra, tony.luck
+Tony
On Wed, Jan 2, 2019 at 11:50 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> On 1/2/19 4:58 PM, Sinan Kaya wrote:
> > On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
> > <pierre-louis.bossart@linux.intel.com> wrote:
> >>
> >>> This is pointing to a kconfig issue on ia64 arch.
> >>>
> >>> arch/ia64/Kconfig:128:error: recursive dependency detected!
> >>> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> >>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
> >>>
> >>> IA64_HP_SIM is both a choice and is selected.
> >>>
> >>> I did allyesconfig and disabled PCI afterwards to find all the issues
> >>> on this patchset.
> >> Are you saying there's a newer series that fixes this issue for both
> >> allyesconfig and allmodconfig?
> >>
> >> if yes, then we're good.
> >
> > No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
> > used allyesconfig to find out all compilation issues on x86 arch to
> > come up with this patchset.
>
> Nothing makes me cringe more than "somebody else's job" statements. In
> this case, there is obviously a correlation with your ACPI changes since
> the circular dependency happens because of the ACPI symbol.
>
I agree that it needs to be fixed. I am not convinced that the issue
is related to my change.
Your log is pointing to an inconsistency in ia64 kconfig.
> arch/ia64/Kconfig:126:error: recursive dependency detected!
> arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
> kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
> kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
> kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
> HIBERNATION
> kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
> init/Kconfig:250: symbol SWAP depends on BLOCK
> block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
> fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
> fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
> drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
> drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
> <<<< LOOK HERE
I am still having hard time seeing how this issue is exposed by
removing PCI dependency from ACPi.
Rafael, Tony:
can you help me?
> drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
> IA64_HP_SIM
> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
>
> At any rate, a 3 mn git bisect tells me the circular dependency is
> exposed by this change:
>
> f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
> commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date: Sat Dec 8 12:21:38 2018 +0530
>
> fscrypt: remove filesystem specific build config option
>
> In order to have a common code base for fscrypt "post read" processing
> for all filesystems which support encryption, this commit removes
> filesystem specific build config option (e.g.
> CONFIG_EXT4_FS_ENCRYPTION)
> and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
> value affects all the filesystems making use of fscrypt.
>
> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>
> -Pierre
>
>
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 23:50 ` Pierre-Louis Bossart
2019-01-03 3:28 ` Sinan Kaya
@ 2019-01-03 4:08 ` Chandan Rajendra
2019-01-03 9:52 ` Rafael J. Wysocki
1 sibling, 1 reply; 37+ messages in thread
From: Chandan Rajendra @ 2019-01-03 4:08 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Sinan Kaya, moderated list:INTEL ASoC DRIVERS, Mark Brown,
Jie Yang, Takashi Iwai, open list, Liam Girdwood,
ACPI Devel Mailing List, Linux Next Mailing List,
Chandan Rajendra, Ted Ts'o
On Thursday, January 3, 2019 5:20:27 AM IST Pierre-Louis Bossart wrote:
>
> On 1/2/19 4:58 PM, Sinan Kaya wrote:
> > On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
> > <pierre-louis.bossart@linux.intel.com> wrote:
> >>
> >>> This is pointing to a kconfig issue on ia64 arch.
> >>>
> >>> arch/ia64/Kconfig:128:error: recursive dependency detected!
> >>> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> >>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
> >>>
> >>> IA64_HP_SIM is both a choice and is selected.
> >>>
> >>> I did allyesconfig and disabled PCI afterwards to find all the issues
> >>> on this patchset.
> >> Are you saying there's a newer series that fixes this issue for both
> >> allyesconfig and allmodconfig?
> >>
> >> if yes, then we're good.
> >
> > No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
> > used allyesconfig to find out all compilation issues on x86 arch to
> > come up with this patchset.
>
> Nothing makes me cringe more than "somebody else's job" statements. In
> this case, there is obviously a correlation with your ACPI changes since
> the circular dependency happens because of the ACPI symbol.
>
> arch/ia64/Kconfig:126:error: recursive dependency detected!
> arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
> kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
> kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
> kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
> HIBERNATION
> kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
> init/Kconfig:250: symbol SWAP depends on BLOCK
> block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
> fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
> fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
> drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
> drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
> <<<< LOOK HERE
> drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
> IA64_HP_SIM
> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
>
> At any rate, a 3 mn git bisect tells me the circular dependency is
> exposed by this change:
>
> f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
> commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date: Sat Dec 8 12:21:38 2018 +0530
>
> fscrypt: remove filesystem specific build config option
>
> In order to have a common code base for fscrypt "post read" processing
> for all filesystems which support encryption, this commit removes
> filesystem specific build config option (e.g.
> CONFIG_EXT4_FS_ENCRYPTION)
> and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
> value affects all the filesystems making use of fscrypt.
>
> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>
FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this
problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
--
chandan
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-03 4:08 ` Chandan Rajendra
@ 2019-01-03 9:52 ` Rafael J. Wysocki
2019-01-03 16:28 ` Pierre-Louis Bossart
0 siblings, 1 reply; 37+ messages in thread
From: Rafael J. Wysocki @ 2019-01-03 9:52 UTC (permalink / raw)
To: Chandan Rajendra, Pierre-Louis Bossart
Cc: Sinan Kaya, moderated list:INTEL ASoC DRIVERS, Mark Brown,
Jie Yang, Takashi Iwai, open list, Liam Girdwood,
ACPI Devel Mailing List, Linux Next Mailing List,
Chandan Rajendra, Ted Ts'o
On Thu, Jan 3, 2019 at 5:08 AM Chandan Rajendra <chandan@linux.ibm.com> wrote:
>
> On Thursday, January 3, 2019 5:20:27 AM IST Pierre-Louis Bossart wrote:
> >
> > On 1/2/19 4:58 PM, Sinan Kaya wrote:
> > > On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
> > > <pierre-louis.bossart@linux.intel.com> wrote:
> > >>
> > >>> This is pointing to a kconfig issue on ia64 arch.
> > >>>
> > >>> arch/ia64/Kconfig:128:error: recursive dependency detected!
> > >>> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> > >>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
> > >>>
> > >>> IA64_HP_SIM is both a choice and is selected.
> > >>>
> > >>> I did allyesconfig and disabled PCI afterwards to find all the issues
> > >>> on this patchset.
> > >> Are you saying there's a newer series that fixes this issue for both
> > >> allyesconfig and allmodconfig?
> > >>
> > >> if yes, then we're good.
> > >
> > > No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
> > > used allyesconfig to find out all compilation issues on x86 arch to
> > > come up with this patchset.
> >
> > Nothing makes me cringe more than "somebody else's job" statements. In
> > this case, there is obviously a correlation with your ACPI changes since
> > the circular dependency happens because of the ACPI symbol.
> >
> > arch/ia64/Kconfig:126:error: recursive dependency detected!
> > arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
> > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
> > kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
> > kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
> > kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
> > HIBERNATION
> > kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
> > init/Kconfig:250: symbol SWAP depends on BLOCK
> > block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
> > fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
> > fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
> > drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
> > drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
> > <<<< LOOK HERE
> > drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
> > IA64_HP_SIM
> > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
> >
> > At any rate, a 3 mn git bisect tells me the circular dependency is
> > exposed by this change:
> >
> > f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
> > commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
> > Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Date: Sat Dec 8 12:21:38 2018 +0530
> >
> > fscrypt: remove filesystem specific build config option
> >
> > In order to have a common code base for fscrypt "post read" processing
> > for all filesystems which support encryption, this commit removes
> > filesystem specific build config option (e.g.
> > CONFIG_EXT4_FS_ENCRYPTION)
> > and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
> > value affects all the filesystems making use of fscrypt.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> >
>
> FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this
> problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
OK
Pierre-Louis, can you check if this patch makes the issue go away for
you, please?
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-03 9:52 ` Rafael J. Wysocki
@ 2019-01-03 16:28 ` Pierre-Louis Bossart
2019-01-04 10:55 ` Chandan Rajendra
0 siblings, 1 reply; 37+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-03 16:28 UTC (permalink / raw)
To: Rafael J. Wysocki, Chandan Rajendra
Cc: moderated list:INTEL ASoC DRIVERS, Sinan Kaya, Jie Yang,
Takashi Iwai, open list, Liam Girdwood, ACPI Devel Mailing List,
Mark Brown, Linux Next Mailing List, Ted Ts'o,
Chandan Rajendra
>>> arch/ia64/Kconfig:126:error: recursive dependency detected!
>>> arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
>>> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
>>> kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
>>> kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
>>> kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
>>> HIBERNATION
>>> kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
>>> init/Kconfig:250: symbol SWAP depends on BLOCK
>>> block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
>>> fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
>>> fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
>>> drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
>>> drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
>>> <<<< LOOK HERE
>>> drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
>>> IA64_HP_SIM
>>> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
>>>
>>> At any rate, a 3 mn git bisect tells me the circular dependency is
>>> exposed by this change:
>>>
>>> f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
>>> commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
>>> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>>> Date: Sat Dec 8 12:21:38 2018 +0530
>>>
>>> fscrypt: remove filesystem specific build config option
>>>
>>> In order to have a common code base for fscrypt "post read" processing
>>> for all filesystems which support encryption, this commit removes
>>> filesystem specific build config option (e.g.
>>> CONFIG_EXT4_FS_ENCRYPTION)
>>> and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
>>> value affects all the filesystems making use of fscrypt.
>>>
>>> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>>> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>>>
>> FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this
>> problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
> OK
>
> Pierre-Louis, can you check if this patch makes the issue go away for
> you, please?
Wondering if Chandan provided the right pointer, I wasn't able to apply
this patch, but commenting out "select BLOCK if FS_ENCRYPTION" in
fs/ubifs/Kconfig makes the circular dependency go away. All good for me.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-03 16:28 ` Pierre-Louis Bossart
@ 2019-01-04 10:55 ` Chandan Rajendra
0 siblings, 0 replies; 37+ messages in thread
From: Chandan Rajendra @ 2019-01-04 10:55 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Rafael J. Wysocki, moderated list:INTEL ASoC DRIVERS, Sinan Kaya,
Jie Yang, Takashi Iwai, open list, Liam Girdwood,
ACPI Devel Mailing List, Mark Brown, Linux Next Mailing List,
Ted Ts'o, Chandan Rajendra
On Thursday, January 3, 2019 9:58:28 PM IST Pierre-Louis Bossart wrote:
>
> >>> arch/ia64/Kconfig:126:error: recursive dependency detected!
> >>> arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
> >>> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
> >>> kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
> >>> kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
> >>> kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
> >>> HIBERNATION
> >>> kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
> >>> init/Kconfig:250: symbol SWAP depends on BLOCK
> >>> block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
> >>> fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
> >>> fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
> >>> drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
> >>> drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
> >>> <<<< LOOK HERE
> >>> drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
> >>> IA64_HP_SIM
> >>> arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
> >>>
> >>> At any rate, a 3 mn git bisect tells me the circular dependency is
> >>> exposed by this change:
> >>>
> >>> f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
> >>> commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
> >>> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> >>> Date: Sat Dec 8 12:21:38 2018 +0530
> >>>
> >>> fscrypt: remove filesystem specific build config option
> >>>
> >>> In order to have a common code base for fscrypt "post read" processing
> >>> for all filesystems which support encryption, this commit removes
> >>> filesystem specific build config option (e.g.
> >>> CONFIG_EXT4_FS_ENCRYPTION)
> >>> and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
> >>> value affects all the filesystems making use of fscrypt.
> >>>
> >>> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> >>> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> >>>
> >> FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this
> >> problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
> > OK
> >
> > Pierre-Louis, can you check if this patch makes the issue go away for
> > you, please?
>
> Wondering if Chandan provided the right pointer, I wasn't able to apply
> this patch, but commenting out "select BLOCK if FS_ENCRYPTION" in
> fs/ubifs/Kconfig makes the circular dependency go away. All good for me.
>
V4 version of the patchset (which is part of linux-next) had introduced the
"select BLOCK if FS_ENCRYPTION". The V5 patchset omits that line. Hence the
patch did not apply cleanly. However just commenting out that line was the
right thing to do.
--
chandan
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
@ 2019-01-03 12:33 ` Mark Brown
2019-01-03 12:43 ` Rafael J. Wysocki
1 sibling, 1 reply; 37+ messages in thread
From: Mark Brown @ 2019-01-03 12:33 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Wed, Jan 02, 2019 at 06:10:35PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
> IOSF_MBI driver.
I still don't understand what's going on with dependencies here and
still don't have the cover letter or anything :( . As far as I can tell
the above commit is in Linus' tree so I'd expect I can just apply it
directly but you were saying that this needs to go via some other tree
so I'm a bit confused as to what's going on here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-03 12:33 ` Mark Brown
@ 2019-01-03 12:43 ` Rafael J. Wysocki
0 siblings, 0 replies; 37+ messages in thread
From: Rafael J. Wysocki @ 2019-01-03 12:43 UTC (permalink / raw)
To: Mark Brown
Cc: Sinan Kaya, Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On Thu, Jan 3, 2019 at 1:34 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Jan 02, 2019 at 06:10:35PM +0000, Sinan Kaya wrote:
>
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
> > on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
> > IOSF_MBI driver.
>
> I still don't understand what's going on with dependencies here and
> still don't have the cover letter or anything :( . As far as I can tell
> the above commit is in Linus' tree so I'd expect I can just apply it
> directly
Yes, you can.
> but you were saying that this needs to go via some other tree
> so I'm a bit confused as to what's going on here.
I guess Sinan wanted it to go in via the ACPI tree like 5d32a66541c4,
but that of course isn't necessary.
If you want to pick up anything from this series, please do. I will
pick up what's left. :-)
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (7 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-03 14:49 ` Adrian Hunter
2019-01-02 18:10 ` [PATCH v5 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Faiz Abbas, Masahiro Yamada, Geert Uytterhoeven, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..1b9401fe94c0 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -116,7 +116,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
- depends on MMC_SDHCI && ACPI
+ depends on MMC_SDHCI && ACPI && PCI
select IOSF_MBI if X86
help
This selects support for ACPI enumerated SDHCI controllers,
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: " Sinan Kaya
@ 2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:57 ` Sinan Kaya
0 siblings, 1 reply; 37+ messages in thread
From: Adrian Hunter @ 2019-01-03 14:49 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: linux-acpi, Ulf Hansson, Shawn Lin, Faiz Abbas, Masahiro Yamada,
Geert Uytterhoeven, Chunyan Zhang, Jisheng Zhang, Ludovic Barre,
Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list
On 2/01/19 8:10 PM, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
This driver does not rely on IOSF_MBI
You wrote on the other email QCOM doesn't use PCI but here you are making
them depend on it. Please explain.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..1b9401fe94c0 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> - depends on MMC_SDHCI && ACPI
> + depends on MMC_SDHCI && ACPI && PCI
> select IOSF_MBI if X86
> help
> This selects support for ACPI enumerated SDHCI controllers,
>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-03 14:49 ` Adrian Hunter
@ 2019-01-03 14:57 ` Sinan Kaya
0 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-03 14:57 UTC (permalink / raw)
To: Adrian Hunter
Cc: Linux Next Mailing List, ACPI Devel Mailing List, Ulf Hansson,
Shawn Lin, Faiz Abbas, Masahiro Yamada, Geert Uytterhoeven,
Chunyan Zhang, Jisheng Zhang, Ludovic Barre, Arnd Bergmann,
Alex Smith, Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
On Thu, Jan 3, 2019 at 2:50 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 2/01/19 8:10 PM, Sinan Kaya wrote:
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> > on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> This driver does not rely on IOSF_MBI
>
X86 version does.
select IOSF_MBI if X86
> You wrote on the other email QCOM doesn't use PCI but here you are making
> them depend on it. Please explain.
>
I matched the behavior before my change. This code wouldn't be
available without PCI and ACPI on previous kernel versions and left
kconfig cleanup as another exercise for some other day.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index e26b8145efb3..1b9401fe94c0 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
> >
> > config MMC_SDHCI_ACPI
> > tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> > - depends on MMC_SDHCI && ACPI
> > + depends on MMC_SDHCI && ACPI && PCI
> > select IOSF_MBI if X86
> > help
> > This selects support for ACPI enumerated SDHCI controllers,
> >
>
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 10/11] x86/intel/lpss: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (8 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-11 18:36 ` [tip:x86/urgent] " tip-bot for Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 1 reply; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. LPSS code relies on PCI infrastructure but this
dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* [tip:x86/urgent] x86/intel/lpss: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 10/11] x86/intel/lpss: " Sinan Kaya
@ 2019-01-11 18:36 ` tip-bot for Sinan Kaya
0 siblings, 0 replies; 37+ messages in thread
From: tip-bot for Sinan Kaya @ 2019-01-11 18:36 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, hpa, tglx, linux-kernel, x86, bp, okaya
Commit-ID: 5962dd22f0ff6f7d72fff974b3c637d52586643e
Gitweb: https://git.kernel.org/tip/5962dd22f0ff6f7d72fff974b3c637d52586643e
Author: Sinan Kaya <okaya@kernel.org>
AuthorDate: Wed, 2 Jan 2019 18:10:37 +0000
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Fri, 11 Jan 2019 19:32:22 +0100
x86/intel/lpss: Make PCI dependency explicit
After commit
5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
dependencies on CONFIG_PCI that previously were satisfied implicitly
through dependencies on CONFIG_ACPI have to be specified directly. LPSS
code relies on PCI infrastructure but this dependency has not been
explicitly called out so do that.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-acpi@vger.kernel.org
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190102181038.4418-11-okaya@kernel.org
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 15af091611e2..4b4a7f32b68e 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
^ permalink raw reply related [flat|nested] 37+ messages in thread
* [PATCH v5 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
` (9 preceding siblings ...)
2019-01-02 18:10 ` [PATCH v5 10/11] x86/intel/lpss: " Sinan Kaya
@ 2019-01-02 18:10 ` Sinan Kaya
10 siblings, 0 replies; 37+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. IOSF_CORE depends on PCI. For this reason, add a
direct dependency on CONFIG_PCI.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 37+ messages in thread