linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, Pavel.Tatashin@microsoft.com,
	mingo@kernel.org, mgorman@techsingularity.net,
	iamjoonsoo.kim@lge.com, tglx@linutronix.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_owner: fix for deferred struct page init
Date: Thu, 3 Jan 2019 21:22:35 +0100	[thread overview]
Message-ID: <20190103202235.GE31793@dhcp22.suse.cz> (raw)
In-Reply-To: <62e96e34-7ea9-491a-b5b6-4828da980d48@lca.pw>

On Thu 03-01-19 14:53:47, Qian Cai wrote:
> On 1/3/19 2:07 PM, Michal Hocko wrote> So can we make the revert with an
> explanation that the patch was wrong?
> > If we want to make hacks to catch more objects to be tracked then it
> > would be great to have some numbers in hands.
> 
> Well, those numbers are subject to change depends on future start_kernel()
> order. Right now, there are many functions could be caught earlier by page owner.
> 
> 	kmemleak_init();
[...]
> 	sched_init_smp();

The kernel source dump will not tell us much of course. A ball park
number whether we are talking about dozen, hundreds or thousands of
allocations would tell us something at least, doesn't it.

Handwaving that it might help us some is not particurarly useful. We are
already losing some allocations already. Does it matter? Well, that
depends, sometimes we do want to catch an owner of particular page and
it is sad to find nothing. But how many times have you or somebody else
encountered that in practice. That is exactly a useful information to
judge an ugly ifdefery in the code. See my point?

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2019-01-03 20:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1545172285.18411.26.camel@lca.pw>
2018-12-19  1:57 ` [PATCH] mm: skip checking poison pattern for page_to_nid() Qian Cai
2018-12-19 10:20   ` Michal Hocko
2018-12-19 12:46     ` Qian Cai
2018-12-20  6:03       ` [PATCH] mm/page_owner: fix for deferred struct page init Qian Cai
2018-12-20  9:22         ` Michal Hocko
2018-12-20 18:50           ` [PATCH v2] " Qian Cai
2018-12-20 20:31             ` [PATCH v3] " Qian Cai
2018-12-20 21:00               ` William Kucharski
2018-12-20 21:04                 ` Qian Cai
2019-01-03 11:51               ` Michal Hocko
2019-01-03 16:38                 ` Qian Cai
2019-01-03 16:59                   ` Michal Hocko
2019-01-03 17:38                     ` Qian Cai
2019-01-03 19:07                       ` Michal Hocko
2019-01-03 19:53                         ` Qian Cai
2019-01-03 20:22                           ` Michal Hocko [this message]
2019-01-03 22:22                             ` Qian Cai
2019-01-04 13:09                               ` Michal Hocko
2019-01-04 15:01                                 ` Qian Cai
2019-01-04 15:17                                   ` Michal Hocko
2019-01-04 15:25                                     ` Qian Cai
2019-01-04 15:32                                       ` Michal Hocko
2019-01-04 20:18                                         ` Qian Cai
2019-01-07 18:43                                           ` Michal Hocko
2019-01-08  1:53                                             ` Qian Cai
2019-01-08  8:20                                               ` Michal Hocko
2019-01-08 13:19                                                 ` Qian Cai
2019-01-08 22:02                                                   ` Andrew Morton
2019-01-08 22:13                                                     ` Qian Cai
2019-01-08 22:40                                                       ` Michal Hocko
2019-01-09  7:34             ` [PATCH v2] " Michal Hocko
2019-01-15 20:28               ` [PATCH] Revert "mm: use early_pfn_to_nid in page_ext_init" Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103202235.GE31793@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=Pavel.Tatashin@microsoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).