From: Wolfram Sang <wsa@the-dreams.de>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Timo Alho <talho@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH V3] i2c: tegra: Fix Maximum transfer size
Date: Thu, 3 Jan 2019 22:46:32 +0100 [thread overview]
Message-ID: <20190103214632.GA1421@kunai> (raw)
In-Reply-To: <BN7PR12MB28368BFA8C7DB877316960EFC28D0@BN7PR12MB2836.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Thu, Jan 03, 2019 at 07:47:21PM +0000, Sowjanya Komatineni wrote:
>
> >> Tegra194 supports maximum 64K Bytes transfer per packet.
> >> Tegra186 and prior supports maximum 4K Bytes transfer per packet.
> >>
> >> This patch fixes this payload difference between Tegra194 and prior
> >> tegra chipsets using separate i2c_adapter_quirks.
> >>
> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> >
> > CC drivers/i2c/busses/i2c-tegra.o
> >drivers/i2c/busses/i2c-tegra.c:171: warning: Function parameter or member 'quirks' not described in >'tegra_i2c_hw_feature'
> >
> Somehow I don't see this warning. Do I need to document somewhere on quirks member of tegra_i2c_hw_feature?
Yes, the kerneldoc above tegra_i2c_hw_feature.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-01-03 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 23:40 [PATCH V3] i2c: tegra: Fix Maximum transfer size Sowjanya Komatineni
2019-01-03 8:55 ` Thierry Reding
2019-01-03 19:05 ` Wolfram Sang
2019-01-03 19:47 ` Sowjanya Komatineni
2019-01-03 21:46 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103214632.GA1421@kunai \
--to=wsa@the-dreams.de \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).