From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8936EC43387 for ; Fri, 4 Jan 2019 07:33:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DF242184B for ; Fri, 4 Jan 2019 07:33:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725958AbfADHdg (ORCPT ); Fri, 4 Jan 2019 02:33:36 -0500 Received: from mga02.intel.com ([134.134.136.20]:39683 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbfADHdg (ORCPT ); Fri, 4 Jan 2019 02:33:36 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 23:33:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,437,1539673200"; d="scan'208";a="115385098" Received: from tiwuxiex-mobl.ccr.corp.intel.com (HELO wfg-t570.sh.intel.com) ([10.254.213.147]) by orsmga003.jf.intel.com with ESMTP; 03 Jan 2019 23:33:32 -0800 Received: from wfg by wfg-t570.sh.intel.com with local (Exim 4.89) (envelope-from ) id 1gfJz2-0001tF-2B; Fri, 04 Jan 2019 15:33:32 +0800 Date: Fri, 4 Jan 2019 15:33:32 +0800 From: Fengguang Wu To: Dmitry Vyukov Cc: Sergey Senozhatsky , Tetsuo Handa , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Andrew Morton , LKML , syzkaller , Kevin Hilman , "Li, Philip" , Huang Ying Subject: Re: [PATCH] printk: Add caller information to printk() output. Message-ID: <20190104073332.qxq2pi44xsmgokaq@wfg-t540p.sh.intel.com> References: <20181213121847.mwlr2vyv6qzclhk6@pathway.suse.cz> <20181213124255.GB3053@tigerII.localdomain> <20181217145452.3kev4rmo2l5lt2qy@pathway.suse.cz> <93f19e57-5051-c67d-9af4-b17624062d44@i-love.sakura.ne.jp> <20181218083911.qxvlqlwlb4eye72x@pathway.suse.cz> <20181218085833.GA460@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 03, 2019 at 07:27:41PM +0100, Dmitry Vyukov wrote: >On Wed, Jan 2, 2019 at 5:09 PM Dmitry Vyukov wrote: >> >> On Tue, Dec 18, 2018 at 9:58 AM Sergey Senozhatsky >> wrote: >> > >> > On (12/18/18 09:39), Petr Mladek wrote: >> > > >> > > Sergey, are you okay with this squashed patch, please? >> > > >> > >> > Yeah. There are several minor nitpicks, but here is my >> > Acked-by: Sergey Senozhatsky >> > >> > >> > One final question - can syzbot folks confirm that the patch >> > helps? Just curious. >> >> This slip through the cracks. Tetsuo pinged me and I am testing now. >> Need to create a set of tests and update parsing code to handle this. > >I've pushed support for CONFIG_PRINTK_CALLER to syzkaller/syzbot: >https://github.com/google/syzkaller/commit/7da2392541a49c3f17b2e7d24e04b84d72b965fb >Let's see what happens. Limited local testing shows that it's working >as intended and significatly improves quality of reports and ability >to make sense out of kernel output. > >Tetsuo, thanks for your great persistence with this change! >Sergey, Petr, thanks for reviews! > >+Fengguang, Kevin, maybe you will find this useful for 0-day/kernel-ci. Thanks! We'll try out CONFIG_PRINTK_CALLER. Regards, Fengguang