From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFE8C43387 for ; Fri, 4 Jan 2019 08:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58AF12184B for ; Fri, 4 Jan 2019 08:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546592284; bh=PRS8U9Vn+nRtCu4gIz7Mf8QdzyXZSLfnBgDV54gDGng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FON/kApNfiBisTV57UHlSBSGVS3k8TsSvHPloG22fMEjt4Tca006t51XKJO1FnUHk q9PAT+LEgHNbjZQLItDB3yyuw8qnaN46d3SsUEOpgs89FSx79e/P7fFnAZupQsaQS7 XiORBBO0ZSVuvykOAZmzy9xS41CTH1zDMFkU8QS0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725913AbfADI6D (ORCPT ); Fri, 4 Jan 2019 03:58:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:33576 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726817AbfADI6D (ORCPT ); Fri, 4 Jan 2019 03:58:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CF1C3AC6E; Fri, 4 Jan 2019 08:58:01 +0000 (UTC) Date: Fri, 4 Jan 2019 09:58:01 +0100 From: Michal Hocko To: Arun KS Cc: arunks.linux@gmail.com, akpm@linux-foundation.org, vbabka@suse.cz, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, getarunks@gmail.com Subject: Re: [PATCH v6 1/2] memory_hotplug: Free pages as higher order Message-ID: <20190104085801.GH31793@dhcp22.suse.cz> References: <1541484194-1493-1-git-send-email-arunks@codeaurora.org> <20181106140638.GN27423@dhcp22.suse.cz> <542cd3516b54d88d1bffede02c6045b8@codeaurora.org> <20181106200823.GT27423@dhcp22.suse.cz> <5e55c6e64a2bfd6eed855ea17a34788b@codeaurora.org> <40a4d5154fbd0006fbe55eb68703bb65@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40a4d5154fbd0006fbe55eb68703bb65@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 04-01-19 10:35:58, Arun KS wrote: > On 2018-11-07 11:51, Arun KS wrote: > > On 2018-11-07 01:38, Michal Hocko wrote: > > > On Tue 06-11-18 21:01:29, Arun KS wrote: > > > > On 2018-11-06 19:36, Michal Hocko wrote: > > > > > On Tue 06-11-18 11:33:13, Arun KS wrote: > > > > > > When free pages are done with higher order, time spend on > > > > > > coalescing pages by buddy allocator can be reduced. With > > > > > > section size of 256MB, hot add latency of a single section > > > > > > shows improvement from 50-60 ms to less than 1 ms, hence > > > > > > improving the hot add latency by 60%. Modify external > > > > > > providers of online callback to align with the change. > > > > > > > > > > > > This patch modifies totalram_pages, zone->managed_pages and > > > > > > totalhigh_pages outside managed_page_count_lock. A follow up > > > > > > series will be send to convert these variable to atomic to > > > > > > avoid readers potentially seeing a store tear. > > > > > > > > > > Is there any reason to rush this through rather than wait for counters > > > > > conversion first? > > > > > > > > Sure Michal. > > > > > > > > Conversion patch, https://patchwork.kernel.org/cover/10657217/ > > > > is currently > > > > incremental to this patch. > > > > > > The ordering should be other way around. Because as things stand with > > > this patch first it is possible to introduce a subtle race prone > > > updates. As I've said I am skeptical the race would matter, really, > > > but > > > there is no real reason to risk for that. Especially when you have the > > > other (first) half ready. > > > > Makes sense. I have rebased the preparatory patch on top of -rc1. > > https://patchwork.kernel.org/patch/10670787/ > > Hello Michal, > > Please review version 7 sent, > https://lore.kernel.org/patchwork/patch/1028908/ I believe I have give my Acked-by to this version already, and v7 indeed has it. Are there any relevant changes since v6 for me to do the review again. If yes you should have dropped the Acked-by. -- Michal Hocko SUSE Labs