From: Olof Johansson <olof@lixom.net>
To: John Garry <john.garry@huawei.com>
Cc: xuwei5@huawei.com, arm@kernel.org, linuxarm@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HISI LPC: Don't fail probe for unrecognised child devices
Date: Fri, 4 Jan 2019 14:25:21 -0800 [thread overview]
Message-ID: <20190104222521.6r7lmz7so22xu2nj@localhost> (raw)
In-Reply-To: <1546516622-46343-1-git-send-email-john.garry@huawei.com>
On Thu, Jan 03, 2019 at 07:57:02PM +0800, John Garry wrote:
> Currently for ACPI-based FW we fail the probe for an unrecognised child
> HID.
>
> However, there is FW in the field with LPC child devices having fake HIDs,
> namely "IPI0002", which was an IPMI device invented to support the
> initial out-of-tree LPC host driver, different from the final mainline
> version.
>
> To provide compatibility support for these dodgy FWs, just discard the
> unrecognised HIDs instead of failing the probe altogether.
>
> Tested-by: Zengruan Ye <yezengruan@huawei.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index d5f8545..19d7b6f 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>
> if (!found) {
> dev_warn(hostdev,
> - "could not find cell for child device (%s)\n",
> + "could not find cell for child device (%s), discarding\n",
> hid);
> - ret = -ENODEV;
> - goto fail;
> + continue;
> }
This driver is the equivalent of a board file. Wasn't ACPI supposed to
spare us from these platform device tables? It even has hardcoded clock
information in it. :(
Also, we were told that there'll be expectations for users to update
their ACPI tables if they're incompatible our out of date. Can that be done
here as well?
-Olof
next prev parent reply other threads:[~2019-01-04 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 11:57 [PATCH] HISI LPC: Don't fail probe for unrecognised child devices John Garry
2019-01-04 22:25 ` Olof Johansson [this message]
2019-01-07 10:31 ` John Garry
2019-02-08 9:49 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104222521.6r7lmz7so22xu2nj@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).