linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] qcom_adsp_pil: Remove voting for lpass_aon clock
@ 2018-11-30  7:29 Rohit kumar
  2018-11-30  7:29 ` [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list Rohit kumar
  2018-11-30  7:29 ` [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock Rohit kumar
  0 siblings, 2 replies; 9+ messages in thread
From: Rohit kumar @ 2018-11-30  7:29 UTC (permalink / raw)
  To: ohad, bjorn.andersson, robh+dt, mark.rutland, linux-remoteproc,
	devicetree, linux-kernel, plai, bgoswami
  Cc: Rohit kumar

LPASS Audio Wrapper AON clock is on by default. Remove
voting for it.

Rohit kumar (2):
  dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock
    list
  remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
 drivers/remoteproc/qcom_q6v5_adsp.c                            | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list
  2018-11-30  7:29 [PATCH 0/2] qcom_adsp_pil: Remove voting for lpass_aon clock Rohit kumar
@ 2018-11-30  7:29 ` Rohit kumar
  2018-12-12  2:32   ` Rob Herring
  2018-11-30  7:29 ` [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock Rohit kumar
  1 sibling, 1 reply; 9+ messages in thread
From: Rohit kumar @ 2018-11-30  7:29 UTC (permalink / raw)
  To: ohad, bjorn.andersson, robh+dt, mark.rutland, linux-remoteproc,
	devicetree, linux-kernel, plai, bgoswami
  Cc: Rohit kumar

LPASS_Audio_Wrapper_AON clock is on by default. Remove
it from lpass clock list to avoid voting for it.

Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt
index a842a78..66af2c3 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt
@@ -35,7 +35,7 @@ on the Qualcomm Technology Inc. ADSP Hexagon core.
 	Value type: <stringlist>
 	Definition: List of clock input name strings sorted in the same
 		    order as the clocks property. Definition must have
-		    "xo", "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr",
+		    "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
 		    "lpass_ahbm_aon_cbcr", "qdsp6ss_xo", "qdsp6ss_sleep"
 		    and "qdsp6ss_core".
 
@@ -100,13 +100,12 @@ ADSP, as it is found on SDM845 boards.
 
 		clocks = <&rpmhcc RPMH_CXO_CLK>,
 			<&gcc GCC_LPASS_SWAY_CLK>,
-			<&lpasscc LPASS_AUDIO_WRAPPER_AON_CLK>,
 			<&lpasscc LPASS_Q6SS_AHBS_AON_CLK>,
 			<&lpasscc LPASS_Q6SS_AHBM_AON_CLK>,
 			<&lpasscc LPASS_QDSP6SS_XO_CLK>,
 			<&lpasscc LPASS_QDSP6SS_SLEEP_CLK>,
 			<&lpasscc LPASS_QDSP6SS_CORE_CLK>;
-		clock-names = "xo", "sway_cbcr", "lpass_aon",
+		clock-names = "xo", "sway_cbcr",
 			"lpass_ahbs_aon_cbcr",
 			"lpass_ahbm_aon_cbcr", "qdsp6ss_xo",
 			"qdsp6ss_sleep", "qdsp6ss_core";
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2018-11-30  7:29 [PATCH 0/2] qcom_adsp_pil: Remove voting for lpass_aon clock Rohit kumar
  2018-11-30  7:29 ` [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list Rohit kumar
@ 2018-11-30  7:29 ` Rohit kumar
  2019-01-04  4:36   ` Rohit Kumar
  1 sibling, 1 reply; 9+ messages in thread
From: Rohit kumar @ 2018-11-30  7:29 UTC (permalink / raw)
  To: ohad, bjorn.andersson, robh+dt, mark.rutland, linux-remoteproc,
	devicetree, linux-kernel, plai, bgoswami
  Cc: Rohit kumar

Lpass_aon clock is on by default. Remove it from lpass
clock list to avoid voting for it.

Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---
 drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
index 79374d1..4829173 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -48,7 +48,7 @@
 
 /* list of clocks required by ADSP PIL */
 static const char * const adsp_clk_id[] = {
-	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
+	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
 	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
 };
 
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list
  2018-11-30  7:29 ` [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list Rohit kumar
@ 2018-12-12  2:32   ` Rob Herring
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2018-12-12  2:32 UTC (permalink / raw)
  To: Rohit kumar
  Cc: ohad, bjorn.andersson, robh+dt, mark.rutland, linux-remoteproc,
	devicetree, linux-kernel, plai, bgoswami, Rohit kumar

On Fri, 30 Nov 2018 12:59:09 +0530, Rohit kumar wrote:
> LPASS_Audio_Wrapper_AON clock is on by default. Remove
> it from lpass clock list to avoid voting for it.
> 
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2018-11-30  7:29 ` [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock Rohit kumar
@ 2019-01-04  4:36   ` Rohit Kumar
  2019-01-07  7:13     ` Bjorn Andersson
  0 siblings, 1 reply; 9+ messages in thread
From: Rohit Kumar @ 2019-01-04  4:36 UTC (permalink / raw)
  To: ohad, bjorn.andersson, robh+dt, mark.rutland, linux-remoteproc,
	devicetree, linux-kernel, plai, bgoswami

Hello Bjorn,

Can you please review this patch series too.

LPASS_AON clock support is already removed from lpass clock driver.


Thanks,

Rohit

On 11/30/2018 12:59 PM, Rohit kumar wrote:
> Lpass_aon clock is on by default. Remove it from lpass
> clock list to avoid voting for it.
>
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
>   drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index 79374d1..4829173 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -48,7 +48,7 @@
>   
>   /* list of clocks required by ADSP PIL */
>   static const char * const adsp_clk_id[] = {
> -	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
> +	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
>   	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
>   };
>   

-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2019-01-04  4:36   ` Rohit Kumar
@ 2019-01-07  7:13     ` Bjorn Andersson
  2019-01-14 10:44       ` Rohit Kumar
  0 siblings, 1 reply; 9+ messages in thread
From: Bjorn Andersson @ 2019-01-07  7:13 UTC (permalink / raw)
  To: Rohit Kumar
  Cc: ohad, robh+dt, mark.rutland, linux-remoteproc, devicetree,
	linux-kernel, plai, bgoswami

On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:

> Hello Bjorn,
> 
> Can you please review this patch series too.
> 
> LPASS_AON clock support is already removed from lpass clock driver.
> 

Applied the two patches.

Thanks,
Bjorn

> 
> Thanks,
> 
> Rohit
> 
> On 11/30/2018 12:59 PM, Rohit kumar wrote:
> > Lpass_aon clock is on by default. Remove it from lpass
> > clock list to avoid voting for it.
> > 
> > Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> > ---
> >   drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> > index 79374d1..4829173 100644
> > --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> > @@ -48,7 +48,7 @@
> >   /* list of clocks required by ADSP PIL */
> >   static const char * const adsp_clk_id[] = {
> > -	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
> > +	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
> >   	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
> >   };
> 
> -- 
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2019-01-07  7:13     ` Bjorn Andersson
@ 2019-01-14 10:44       ` Rohit Kumar
  2019-01-30  5:08         ` Rohit Kumar
  0 siblings, 1 reply; 9+ messages in thread
From: Rohit Kumar @ 2019-01-14 10:44 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: ohad, robh+dt, mark.rutland, linux-remoteproc, devicetree,
	linux-kernel, plai, bgoswami


On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
> On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
>
>> Hello Bjorn,
>>
>> Can you please review this patch series too.
>>
>> LPASS_AON clock support is already removed from lpass clock driver.
>>
> Applied the two patches.

Hello Bjorn,


Can you please point me to the tree where this is applied.


Thanks,

Rohit

> Thanks,
> Bjorn
>
>> Thanks,
>>
>> Rohit
>>
>> On 11/30/2018 12:59 PM, Rohit kumar wrote:
>>> Lpass_aon clock is on by default. Remove it from lpass
>>> clock list to avoid voting for it.
>>>
>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>>> ---
>>>    drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
>>> index 79374d1..4829173 100644
>>> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
>>> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
>>> @@ -48,7 +48,7 @@
>>>    /* list of clocks required by ADSP PIL */
>>>    static const char * const adsp_clk_id[] = {
>>> -	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
>>> +	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
>>>    	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
>>>    };
>> -- 
>> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
>> of the Code Aurora Forum, hosted by the Linux Foundation.
>>
-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2019-01-14 10:44       ` Rohit Kumar
@ 2019-01-30  5:08         ` Rohit Kumar
  2019-02-18  4:54           ` Rohit Kumar
  0 siblings, 1 reply; 9+ messages in thread
From: Rohit Kumar @ 2019-01-30  5:08 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: ohad, robh+dt, mark.rutland, linux-remoteproc, devicetree,
	linux-kernel, plai, bgoswami

Hello Bjorn,

On 1/14/2019 4:14 PM, Rohit Kumar wrote:
>
> On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
>> On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
>>
>>> Hello Bjorn,
>>>
>>> Can you please review this patch series too.
>>>
>>> LPASS_AON clock support is already removed from lpass clock driver.
>>>
>> Applied the two patches.
>
I did not see this in next yet. Can you please pick this up.

Thanks,

Rohit

> Hello Bjorn,
>
>
> Can you please point me to the tree where this is applied.
>
>
> Thanks,
>
> Rohit
>
>> Thanks,
>> Bjorn
>>
>>> Thanks,
>>>
>>> Rohit
>>>
>>> On 11/30/2018 12:59 PM, Rohit kumar wrote:
>>>> Lpass_aon clock is on by default. Remove it from lpass
>>>> clock list to avoid voting for it.
>>>>
>>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>>>> ---
>>>>    drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c 
>>>> b/drivers/remoteproc/qcom_q6v5_adsp.c
>>>> index 79374d1..4829173 100644
>>>> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
>>>> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
>>>> @@ -48,7 +48,7 @@
>>>>    /* list of clocks required by ADSP PIL */
>>>>    static const char * const adsp_clk_id[] = {
>>>> -    "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", 
>>>> "lpass_ahbm_aon_cbcr",
>>>> +    "sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
>>>>        "qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
>>>>    };
>>> -- 
>>> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a 
>>> member
>>> of the Code Aurora Forum, hosted by the Linux Foundation.
>>>
-- 

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
  2019-01-30  5:08         ` Rohit Kumar
@ 2019-02-18  4:54           ` Rohit Kumar
  0 siblings, 0 replies; 9+ messages in thread
From: Rohit Kumar @ 2019-02-18  4:54 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: ohad, robh+dt, mark.rutland, linux-remoteproc, devicetree,
	linux-kernel, plai, bgoswami

Hello Bjorn,


On 1/30/2019 10:38 AM, Rohit Kumar wrote:
> Hello Bjorn,
>
> On 1/14/2019 4:14 PM, Rohit Kumar wrote:
>>
>> On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
>>> On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
>>>
>>>> Hello Bjorn,
>>>>
>>>> Can you please review this patch series too.
>>>>
>>>> LPASS_AON clock support is already removed from lpass clock driver.
>>>>
>>> Applied the two patches.
>>
Can you please apply these patches. I don't see them in next.
>>
> I did not see this in next yet. Can you please pick this up.
>
> Thanks,
>
> Rohit
>
>> Hello Bjorn,
>>
>>
>> Can you please point me to the tree where this is applied.
>>
>>
>> Thanks,
>>
>> Rohit
>>
>>> Thanks,
>>> Bjorn
>>>
>>>> Thanks,
>>>>
>>>> Rohit
>>>>
>>>> On 11/30/2018 12:59 PM, Rohit kumar wrote:
>>>>> Lpass_aon clock is on by default. Remove it from lpass
>>>>> clock list to avoid voting for it.
>>>>>
>>>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>>>>> ---
>>>>>    drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c 
>>>>> b/drivers/remoteproc/qcom_q6v5_adsp.c
>>>>> index 79374d1..4829173 100644
>>>>> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
>>>>> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
>>>>> @@ -48,7 +48,7 @@
>>>>>    /* list of clocks required by ADSP PIL */
>>>>>    static const char * const adsp_clk_id[] = {
>>>>> -    "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", 
>>>>> "lpass_ahbm_aon_cbcr",
>>>>> +    "sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
>>>>>        "qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
>>>>>    };
>>>> -- 
>>>> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a 
>>>> member
>>>> of the Code Aurora Forum, hosted by the Linux Foundation.
>>>>
Thanks,

Rohit

-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-02-18  4:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-30  7:29 [PATCH 0/2] qcom_adsp_pil: Remove voting for lpass_aon clock Rohit kumar
2018-11-30  7:29 ` [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list Rohit kumar
2018-12-12  2:32   ` Rob Herring
2018-11-30  7:29 ` [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock Rohit kumar
2019-01-04  4:36   ` Rohit Kumar
2019-01-07  7:13     ` Bjorn Andersson
2019-01-14 10:44       ` Rohit Kumar
2019-01-30  5:08         ` Rohit Kumar
2019-02-18  4:54           ` Rohit Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).