From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC88C43387 for ; Mon, 7 Jan 2019 12:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02AA820859 for ; Mon, 7 Jan 2019 12:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864505; bh=f2lzRGTfXO+yzRn2UIJmrduzJB06iz/BHdu2G2vAxeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cCzSP/9ds8Awm6ROWaHRjP26M9r1IEHgc8aDg44mWcT9qxjrmz6v7gOptAKroxQ09 Hc8mzW3RUJ/PrOn1M8iMXFGTqHqib4uBfGqui/zUgvNZOycrLWvYopxCvDuCkpzr76 +kXQoW3mW/HyUL1mLr8YfGJCUri/NVCOgonUgHU4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727432AbfAGMfE (ORCPT ); Mon, 7 Jan 2019 07:35:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:48176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfAGMfB (ORCPT ); Mon, 7 Jan 2019 07:35:01 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 656FD20859; Mon, 7 Jan 2019 12:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864500; bh=f2lzRGTfXO+yzRn2UIJmrduzJB06iz/BHdu2G2vAxeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cq44Cz7kLiH+5UyCc3ByhUYxhgksONnLFgZrJ9ZwJSBkaphCXcbnvMeI3x3O9NK4u BQaKvVAMrDf3shLiXgCuRzs2eHXkNO7hpfaXAdSy5lQScqyY1xkC6U2Bl3Asr6SrSd VuQJPmioV0XK7O8Iy2Z9ZI/DpKKa7D/IRbL+vBn8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai Subject: [PATCH 4.20 032/145] ALSA: fireface: fix for state to fetch PCM frames Date: Mon, 7 Jan 2019 13:31:09 +0100 Message-Id: <20190107104441.499472098@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Sakamoto commit 3d16200a3e55a39caa1c88419cb559c00316f721 upstream. According to my memo at hand and saved records, writing 0x00000001 to SND_FF_REG_FETCH_PCM_FRAMES disables fetching PCM frames in corresponding channel, however current implement uses reversed logic. This results in muted volume in device side during playback. This commit corrects the bug. Cc: # v4.12+ Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400') Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/fireface/ff-protocol-ff400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/fireface/ff-protocol-ff400.c +++ b/sound/firewire/fireface/ff-protocol-ff400.c @@ -152,7 +152,7 @@ static int ff400_switch_fetching_mode(st if (reg == NULL) return -ENOMEM; - if (enable) { + if (!enable) { /* * Each quadlet is corresponding to data channels in a data * blocks in reverse order. Precisely, quadlets for available