From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A04C43387 for ; Mon, 7 Jan 2019 13:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA39821736 for ; Mon, 7 Jan 2019 13:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546867220; bh=v+71RLh1Rj5NwLf9AxRP5RJV5KMJYNnHaeAbFfrIW60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=V9xBOKPLOmiRcX3OkZ7htLHyyDy0InaDPF7Foe3XXEIgYXo21njiwjBbwe6Nkl+KM yC+DJw+7N4rGFoH/Zi8jOSoYA5sf61pMpSEfPWVgYrWQd8K+Ued5qw3vRxXtyinqse a//JW2IoIIrl22zluO7t0JHk/F7A5Bxb/r2nlo7k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbfAGMrm (ORCPT ); Mon, 7 Jan 2019 07:47:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:37936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728708AbfAGMri (ORCPT ); Mon, 7 Jan 2019 07:47:38 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1934A20651; Mon, 7 Jan 2019 12:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546865257; bh=v+71RLh1Rj5NwLf9AxRP5RJV5KMJYNnHaeAbFfrIW60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fbx6CPOUW0wu+ewR3tCJkJG0UZJ5W1z5LS7F0CpvuDMK+uV5XXFMQqO9pggrvz3pK qakQJDAZ7SZwXmRVoqRTwarOlNnNs68lvhNAy4VbC197j9aHjGGC6hhkAn2o5l2qxK azGlmhTKS/guVnDGpdWbSLhbed8puc8n6zFlzp2o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ying Xue , Jon Maloy , Cong Wang , "David S. Miller" , syzbot+eae585ba2cc2752d3704@syzkaller.appspotmail.com Subject: [PATCH 4.19 036/170] tipc: fix a double kfree_skb() Date: Mon, 7 Jan 2019 13:31:03 +0100 Message-Id: <20190107104457.495853260@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104452.953560660@linuxfoundation.org> References: <20190107104452.953560660@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Wang [ Upstream commit acb4a33e9856d5fa3384b87d3d8369229be06d31 ] tipc_udp_xmit() drops the packet on error, there is no need to drop it again. Fixes: ef20cd4dd163 ("tipc: introduce UDP replicast") Reported-and-tested-by: syzbot+eae585ba2cc2752d3704@syzkaller.appspotmail.com Cc: Ying Xue Cc: Jon Maloy Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/udp_media.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -245,10 +245,8 @@ static int tipc_udp_send_msg(struct net } err = tipc_udp_xmit(net, _skb, ub, src, &rcast->addr); - if (err) { - kfree_skb(_skb); + if (err) goto out; - } } err = 0; out: