From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36AFC43387 for ; Mon, 7 Jan 2019 13:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82DDA21736 for ; Mon, 7 Jan 2019 13:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866124; bh=j+PwJgoTJtZgX7RGQxzs1bTmrFzdZWI1zn9Ptuyw5Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UDYKFE4XiLJHHfuNDmE5tqY4xZ0iD+R6goOZBNGskYh26A4K2A+G8Joia9cWF9vM5 WEO+/6OIydegKeOTfqvhG/6uglJ3pmALEh1inNjecPiHhzqmwqvpHR9R9pE0AjdgWC co5sftDwxZXkieX3WDCoFE3dBRUB/n2zPz8lUDzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730726AbfAGNCD (ORCPT ); Mon, 7 Jan 2019 08:02:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:49372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730706AbfAGNB6 (ORCPT ); Mon, 7 Jan 2019 08:01:58 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A35F52089F; Mon, 7 Jan 2019 13:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866117; bh=j+PwJgoTJtZgX7RGQxzs1bTmrFzdZWI1zn9Ptuyw5Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSOd41wl/fpjPwKaD8nSC9KFHy5Uq3h+YIsDa7ccyZDjJNtQgXMuzL/T/Q3S8zsyr 6GENt86dtm94eE4+ayOSpStzl90mF1xEwBQVx/BNAYPpnF4tJNe90yB8ooLvZ79fup iXGR/FF9QOt5RZkZCgtlBJZOJv2A3Z7+UydBzzG8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Ajay Singh Subject: [PATCH 4.14 052/101] staging: wilc1000: fix missing read_write setting when reading data Date: Mon, 7 Jan 2019 13:32:40 +0100 Message-Id: <20190107105335.769267405@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.372621917@linuxfoundation.org> References: <20190107105330.372621917@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Colin Ian King commit c58eef061dda7d843dcc0ad6fea7e597d4c377c0 upstream. Currently the cmd.read_write setting is not initialized so it contains garbage from the stack. Fix this by setting it to 0 to indicate a read is required. Detected by CoverityScan, CID#1357925 ("Uninitialized scalar variable") Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Colin Ian King Cc: stable Acked-by: Ajay Singh Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/wilc_sdio.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/wilc1000/wilc_sdio.c +++ b/drivers/staging/wilc1000/wilc_sdio.c @@ -823,6 +823,7 @@ static int sdio_read_int(struct wilc *wi if (!g_sdio.irq_gpio) { int i; + cmd.read_write = 0; cmd.function = 1; cmd.address = 0x04; cmd.data = 0;