* [PATCH] samples/seccomp: fix 32-bit build
@ 2019-01-07 23:16 Tycho Andersen
2019-01-07 23:18 ` Kees Cook
2019-01-08 6:48 ` [tip:x86/urgent] samples/seccomp: Fix " tip-bot for Tycho Andersen
0 siblings, 2 replies; 4+ messages in thread
From: Tycho Andersen @ 2019-01-07 23:16 UTC (permalink / raw)
To: Ingo Molnar, Kees Cook
Cc: linux-kernel, James Morris, Borislav Petkov, Thomas Gleixner,
Tycho Andersen
Both the .o and the actual executable need to be built with -m32 in order
to link correctly.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Reported-by: Ingo Molnar <mingo@kernel.org>
Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
---
I guess x86 can pick this up directly? Not sure where it should go
exactly.
---
samples/seccomp/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
index 4920903c8009..fb43a814d4c0 100644
--- a/samples/seccomp/Makefile
+++ b/samples/seccomp/Makefile
@@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG)
HOSTCFLAGS_dropper.o += $(MFLAG)
HOSTCFLAGS_bpf-helper.o += $(MFLAG)
HOSTCFLAGS_bpf-fancy.o += $(MFLAG)
+HOSTCFLAGS_user-trap.o += $(MFLAG)
HOSTLDLIBS_bpf-direct += $(MFLAG)
HOSTLDLIBS_bpf-fancy += $(MFLAG)
HOSTLDLIBS_dropper += $(MFLAG)
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] samples/seccomp: fix 32-bit build
2019-01-07 23:16 [PATCH] samples/seccomp: fix 32-bit build Tycho Andersen
@ 2019-01-07 23:18 ` Kees Cook
2019-01-08 6:43 ` Ingo Molnar
2019-01-08 6:48 ` [tip:x86/urgent] samples/seccomp: Fix " tip-bot for Tycho Andersen
1 sibling, 1 reply; 4+ messages in thread
From: Kees Cook @ 2019-01-07 23:18 UTC (permalink / raw)
To: Tycho Andersen
Cc: Ingo Molnar, LKML, James Morris, Borislav Petkov, Thomas Gleixner
On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen <tycho@tycho.ws> wrote:
>
> Both the .o and the actual executable need to be built with -m32 in order
> to link correctly.
>
> Signed-off-by: Tycho Andersen <tycho@tycho.ws>
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
Reviewed-by: Kees Cook <keescook@chromium.org>
> ---
> I guess x86 can pick this up directly? Not sure where it should go
> exactly.
Ingo, can you snag this? (It's a more direct path, otherwise I can
take it via seccomp, which will go through my tree then James's
tree...)
-Kees
> ---
> samples/seccomp/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
> index 4920903c8009..fb43a814d4c0 100644
> --- a/samples/seccomp/Makefile
> +++ b/samples/seccomp/Makefile
> @@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG)
> HOSTCFLAGS_dropper.o += $(MFLAG)
> HOSTCFLAGS_bpf-helper.o += $(MFLAG)
> HOSTCFLAGS_bpf-fancy.o += $(MFLAG)
> +HOSTCFLAGS_user-trap.o += $(MFLAG)
> HOSTLDLIBS_bpf-direct += $(MFLAG)
> HOSTLDLIBS_bpf-fancy += $(MFLAG)
> HOSTLDLIBS_dropper += $(MFLAG)
> --
> 2.19.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] samples/seccomp: fix 32-bit build
2019-01-07 23:18 ` Kees Cook
@ 2019-01-08 6:43 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2019-01-08 6:43 UTC (permalink / raw)
To: Kees Cook
Cc: Tycho Andersen, LKML, James Morris, Borislav Petkov, Thomas Gleixner
* Kees Cook <keescook@chromium.org> wrote:
> On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen <tycho@tycho.ws> wrote:
> >
> > Both the .o and the actual executable need to be built with -m32 in order
> > to link correctly.
> >
> > Signed-off-by: Tycho Andersen <tycho@tycho.ws>
> > Reported-by: Ingo Molnar <mingo@kernel.org>
> > Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> > ---
> > I guess x86 can pick this up directly? Not sure where it should go
> > exactly.
>
> Ingo, can you snag this? (It's a more direct path, otherwise I can
> take it via seccomp, which will go through my tree then James's
> tree...)
Sure - applied it to x86/urgent.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] samples/seccomp: Fix 32-bit build
2019-01-07 23:16 [PATCH] samples/seccomp: fix 32-bit build Tycho Andersen
2019-01-07 23:18 ` Kees Cook
@ 2019-01-08 6:48 ` tip-bot for Tycho Andersen
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Tycho Andersen @ 2019-01-08 6:48 UTC (permalink / raw)
To: linux-tip-commits
Cc: bp, peterz, linux-kernel, torvalds, keescook, jmorris, tycho,
tglx, mingo, hpa
Commit-ID: a77d1d196bc63b37d9b4d1b614884669e8e79d32
Gitweb: https://git.kernel.org/tip/a77d1d196bc63b37d9b4d1b614884669e8e79d32
Author: Tycho Andersen <tycho@tycho.ws>
AuthorDate: Mon, 7 Jan 2019 16:16:31 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 8 Jan 2019 07:45:01 +0100
samples/seccomp: Fix 32-bit build
Both the .o and the actual executable need to be built with -m32 in order
to link correctly.
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: James Morris <jmorris@namei.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
Link: http://lkml.kernel.org/r/20190107231631.1849-1-tycho@tycho.ws
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
samples/seccomp/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
index 4920903c8009..fb43a814d4c0 100644
--- a/samples/seccomp/Makefile
+++ b/samples/seccomp/Makefile
@@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG)
HOSTCFLAGS_dropper.o += $(MFLAG)
HOSTCFLAGS_bpf-helper.o += $(MFLAG)
HOSTCFLAGS_bpf-fancy.o += $(MFLAG)
+HOSTCFLAGS_user-trap.o += $(MFLAG)
HOSTLDLIBS_bpf-direct += $(MFLAG)
HOSTLDLIBS_bpf-fancy += $(MFLAG)
HOSTLDLIBS_dropper += $(MFLAG)
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-08 6:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 23:16 [PATCH] samples/seccomp: fix 32-bit build Tycho Andersen
2019-01-07 23:18 ` Kees Cook
2019-01-08 6:43 ` Ingo Molnar
2019-01-08 6:48 ` [tip:x86/urgent] samples/seccomp: Fix " tip-bot for Tycho Andersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).