archive mirror
 help / color / mirror / Atom feed
From: Roman Penyaev <>
To: unlisted-recipients:; (no To-header on input)
Cc: Roman Penyaev <>,
	Davidlohr Bueso <>, Jason Baron <>,
	Al Viro <>,
	Andrew Morton <>,
	Linus Torvalds <>,,
Subject: [PATCH 1/1] epoll: remove wrong assert that ep_poll_callback is always called with irqs off
Date: Tue,  8 Jan 2019 11:01:21 +0100	[thread overview]
Message-ID: <> (raw)

That was wrong assumption that all drivers disable irqs before waking up
a wait queue.  Even assert line is removed the whole logic stays correct:
epoll always locks rwlock with irqs disabled and by itself does not call
from interrupts, thus it is up to driver how to call wake_up_locked(),
because if driver does not handle any interrupts (like fuse in the the
report) of course it is safe on its side to take a simple spin_lock.

Signed-off-by: Roman Penyaev <>
Cc: Davidlohr Bueso <>
Cc: Jason Baron <>
Cc: Al Viro <>
Cc: Andrew Morton <>
Cc: Linus Torvalds <>
 fs/eventpoll.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index f307c8679027..f5f88250cdf2 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1217,12 +1217,6 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v
 	__poll_t pollflags = key_to_poll(key);
 	int ewake = 0;
-	/*
-	 * Called by irq context or interrupts are disabled by the wake_up_*poll
-	 * callers.
-	 */
-	lockdep_assert_irqs_disabled();

             reply	other threads:[~2019-01-08 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 10:01 Roman Penyaev [this message]
2019-01-08 12:42 ` Roman Penyaev
2019-01-08 15:16   ` Davidlohr Bueso
2019-01-08 16:07     ` Roman Penyaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/1] epoll: remove wrong assert that ep_poll_callback is always called with irqs off' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox