From: Sam Ravnborg <sam@ravnborg.org>
To: "Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Sean Paul" <sean@poorly.run>,
"David Lechner" <david@lechnology.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v3 0/12] drm: minimize drmP.h dependencies
Date: Tue, 8 Jan 2019 20:29:27 +0100 [thread overview]
Message-ID: <20190108192939.15255-1-sam@ravnborg.org> (raw)
- drmP.h is now stripped down to include files and forward declarations.
- All header files in include/drm/ no longer include drmP.h.
The series was made on top of drm-misc-next
Build tested using arm and x86 all{yes,mod}config
The patches are trivial but touches a lot of files,
so a lot of people on cc: for the individual patches.
I expect the full series to be applied to drm-misc-next
There are still ~700 uses of drmP.h so a long way ahead of
us to get rid of it.
The kernel-doc parts that I authored in the following
may require some extra info as I know too little about
DRM to be able to write something really useful.
Or at least review by someone with knowledge of DRM,
but that goes for everything.
v3:
- Added Acks/Reviewed annotations (thanks!)
- Add forward of drm_gem_object to drm_framebuffer.h (Noralf)
- Drop "drm: move DRM_IF_VERSION to drm_internal.h" as it is applied to drm-misc
- Drop "drm: make drm_file.h self contained" as Jan made a similar patch that was appleid to drm-misc
- Rebased on top of drm-misc-next
v2:
- DRM_SWITCH_POWER as enum (Daniel Vetter)
- Prefer forward decalration over includes (Laurent Pinchart)
- Updated drm_device to use kerneldoc style (Daniel Vetter)
- Improved commit messages (David Lechner)
- Split up patch when removing drmP.h from drm_gem_cma_helper.h
- rebased on top of drm-misc-next
- dropped patch already applied
- added reviewed-by from Laurent Pinchart (Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files
Sam
Sam Ravnborg (12):
drm: drm_device.h: update comments to kernel-doc style
drm: move DRM_SWITCH_POWER defines to drm_device.h
drm: make drm_framebuffer.h self contained
drm: move drm_can_sleep() to drm_util.h
drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
drm: remove include of drmP.h from bridge/dw_hdmi.h
drm: remove include of drmP.h from drm_encoder_slave.h
drm: remove include of drmP.h from drm_modeset_helper.h
drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h
drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h
drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h
drm: remove drmP.h from drm_gem_cma_helper.h
drivers/gpu/drm/amd/amdgpu/atom.c | 2 +
drivers/gpu/drm/arc/arcpgu_crtc.c | 2 +
drivers/gpu/drm/arc/arcpgu_drv.c | 6 +
drivers/gpu/drm/arc/arcpgu_sim.c | 1 +
drivers/gpu/drm/ast/ast_fb.c | 2 +
drivers/gpu/drm/bridge/cdns-dsi.c | 2 +
.../gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 4 +
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 1 +
drivers/gpu/drm/drm_flip_work.c | 1 +
drivers/gpu/drm/drm_framebuffer.c | 1 +
drivers/gpu/drm/drm_modeset_helper.c | 2 +
drivers/gpu/drm/mgag200/mgag200_fb.c | 1 +
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 1 +
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +
drivers/gpu/drm/radeon/atom.c | 2 +
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 +
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 +
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
drivers/gpu/drm/stm/drv.c | 6 +-
drivers/gpu/drm/stm/ltdc.c | 9 +-
drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 3 +
drivers/gpu/drm/tinydrm/hx8357d.c | 1 +
drivers/gpu/drm/tinydrm/ili9225.c | 2 +
drivers/gpu/drm/tinydrm/ili9341.c | 1 +
drivers/gpu/drm/tinydrm/mi0283qt.c | 1 +
drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 +
drivers/gpu/drm/tinydrm/repaper.c | 1 +
drivers/gpu/drm/tinydrm/st7586.c | 1 +
drivers/gpu/drm/tinydrm/st7735r.c | 1 +
drivers/gpu/drm/vc4/vc4_drv.h | 1 +
include/drm/bridge/dw_hdmi.h | 6 +-
include/drm/drmP.h | 24 +--
include/drm/drm_device.h | 228 +++++++++++++++------
include/drm/drm_encoder_slave.h | 1 -
include/drm/drm_framebuffer.h | 10 +-
include/drm/drm_gem_cma_helper.h | 5 +-
include/drm/drm_modeset_helper.h | 6 +-
include/drm/drm_util.h | 52 ++++-
40 files changed, 304 insertions(+), 95 deletions(-)
next reply other threads:[~2019-01-08 19:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 19:29 Sam Ravnborg [this message]
2019-01-08 19:29 ` [PATCH v3 01/12] drm: drm_device.h: update comments to kernel-doc style Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 02/12] drm: move DRM_SWITCH_POWER defines to drm_device.h Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 03/12] drm: make drm_framebuffer.h self contained Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 04/12] drm: move drm_can_sleep() to drm_util.h Sam Ravnborg
2019-01-09 21:20 ` Daniel Vetter
2019-01-08 19:29 ` [PATCH v3 05/12] drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY " Sam Ravnborg
2019-01-09 21:54 ` Daniel Vetter
2019-01-08 19:29 ` [PATCH v3 06/12] drm: remove include of drmP.h from bridge/dw_hdmi.h Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 07/12] drm: remove include of drmP.h from drm_encoder_slave.h Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 08/12] drm: remove include of drmP.h from drm_modeset_helper.h Sam Ravnborg
2019-01-09 21:53 ` Daniel Vetter
2019-01-11 15:56 ` Daniel Vetter
2019-01-08 19:29 ` [PATCH v3 09/12] drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 10/12] drm/stm: " Sam Ravnborg
2019-01-09 8:21 ` Benjamin Gaignard
2019-01-09 9:42 ` Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 11/12] drm/tinydrm: " Sam Ravnborg
2019-01-08 19:29 ` [PATCH v3 12/12] drm: remove " Sam Ravnborg
2019-01-09 22:24 ` Daniel Vetter
2019-01-09 23:06 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108192939.15255-1-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=noralf@tronnes.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).