linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dave Mielke <Dave@mielke.cc>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] vt: always call notifier with the console lock held
Date: Tue,  8 Jan 2019 22:55:00 -0500	[thread overview]
Message-ID: <20190109035504.8413-3-nicolas.pitre@linaro.org> (raw)
In-Reply-To: <20190109035504.8413-1-nicolas.pitre@linaro.org>

Every invocation of notify_write() and notify_update() is performed
under the console lock, except for one case. Let's fix that.

Signed-off-by: Nicolas Pitre <nico@linaro.org>
Cc: stable@vger.kernel.org
---
 drivers/tty/vt/vt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index b9004bd087..5b8b0e33f9 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -2764,8 +2764,8 @@ static int do_con_write(struct tty_struct *tty, const unsigned char *buf, int co
 	con_flush(vc, draw_from, draw_to, &draw_x);
 	vc_uniscr_debug_check(vc);
 	console_conditional_schedule();
-	console_unlock();
 	notify_update(vc);
+	console_unlock();
 	return n;
 }
 
-- 
2.20.1


  parent reply	other threads:[~2019-01-09  3:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  3:54 [PATCH 0/6] assorted console/vt/vcs fixes Nicolas Pitre
2019-01-09  3:54 ` [PATCH 1/6] vt: make vt_console_print() compatible with the unicode screen buffer Nicolas Pitre
2019-01-09  3:55 ` Nicolas Pitre [this message]
2019-01-09  3:55 ` [PATCH 3/6] vt: invoke notifier on screen size change Nicolas Pitre
2019-01-09  3:55 ` [PATCH 4/6] vcsa: clamp header values when they don't fit Nicolas Pitre
2019-01-09  3:55 ` [PATCH 5/6] vcs: poll(): cope with a deallocated vt Nicolas Pitre
2019-01-10  0:13   ` Nicolas Pitre
2019-01-09  3:55 ` [PATCH 6/6] vcs: fasync(): make it consistent with poll() Nicolas Pitre
2019-01-18 12:49 ` [PATCH 0/6] assorted console/vt/vcs fixes Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109035504.8413-3-nicolas.pitre@linaro.org \
    --to=nicolas.pitre@linaro.org \
    --cc=Dave@mielke.cc \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).