From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] tools uapi asm: Update asm-generic/unistd.h
Date: Wed, 9 Jan 2019 10:15:40 -0300 [thread overview]
Message-ID: <20190109131540.GC25192@kernel.org> (raw)
In-Reply-To: <20190108221758.14546-1-labbott@redhat.com>
Em Tue, Jan 08, 2019 at 02:17:58PM -0800, Laura Abbott escreveu:
> Commit 4e21565b7fd4 ("asm-generic: add kexec_file_load system
> call to unistd.h") added the system call to the generic header
> but not to the perf copy resulting a compile failure on aarch64
Humm, that shouldn't happen, i.e. kernel developers don't have to update
anything in tools/ as part of their normal kernel development workflows.
They can if they wish, but are not required, so the build failure was
due to something else or a pre-existing bug where tools/ living stuff
used things outside tools/.
> When running mksyscalltbl
Lemme try this on my Orangi PI zero...
- Arnaldo
> BUILDSTDERR: <stdin>: In function 'main':
> BUILDSTDERR: <stdin>:273:44: error: '__NR_kexec_file_load' undeclared (first use in this function)
> BUILDSTDERR: <stdin>:273:44: note: each undeclared identifier is reported only once for each function it appears in
>
> Fix this by syncing up.
>
> Fixes: 4e21565b7fd4 ("asm-generic: add kexec_file_load system call to unistd.h")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Found this on Fedora when compiling 5.0-rc1, I hadn't seen a patch
> queued yet.
> ---
> tools/include/uapi/asm-generic/unistd.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/include/uapi/asm-generic/unistd.h b/tools/include/uapi/asm-generic/unistd.h
> index c7f3321fbe43..d90127298f12 100644
> --- a/tools/include/uapi/asm-generic/unistd.h
> +++ b/tools/include/uapi/asm-generic/unistd.h
> @@ -738,9 +738,11 @@ __SYSCALL(__NR_statx, sys_statx)
> __SC_COMP(__NR_io_pgetevents, sys_io_pgetevents, compat_sys_io_pgetevents)
> #define __NR_rseq 293
> __SYSCALL(__NR_rseq, sys_rseq)
> +#define __NR_kexec_file_load 294
> +__SYSCALL(__NR_kexec_file_load, sys_kexec_file_load)
>
> #undef __NR_syscalls
> -#define __NR_syscalls 294
> +#define __NR_syscalls 295
>
> /*
> * 32 bit systems traditionally used different
> --
> 2.20.1
--
- Arnaldo
next prev parent reply other threads:[~2019-01-09 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 22:17 [PATCH] tools uapi asm: Update asm-generic/unistd.h Laura Abbott
2019-01-09 13:15 ` Arnaldo Carvalho de Melo [this message]
2019-01-09 15:29 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109131540.GC25192@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jolsa@redhat.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).