From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Marc Dionne <marc.c.dionne@gmail.com>, Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, x86@kernel.org Subject: Re: x86/fpu: Don't export __kernel_fpu_{begin,end}() Date: Wed, 9 Jan 2019 17:52:35 +0100 Message-ID: <20190109165235.GA8151@kroah.com> (raw) In-Reply-To: <20190109111951.5zvnj7ls6jv56p2u@linutronix.de> On Wed, Jan 09, 2019 at 12:19:52PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-01-07 18:08:26 [-0400], Marc Dionne wrote: > > On Thu, Dec 27, 2018 at 11:20 AM Linux Kernel Mailing List > > <linux-kernel@vger.kernel.org> wrote: > > > > > > Commit: 12209993e98c5fa1855c467f22a24e3d5b8be205 > > > x86/fpu: Don't export __kernel_fpu_{begin,end}() > > > > … > > > With EFI gone as the last user of __kernel_fpu_{begin|end}(), both can > > > be made static and not exported anymore. > > > > > This commit removes an exported function pair that is currently used > > by out of tree modules, while the replacement pair > > (kernel_fpu_begin/end) is EXPORT_SYMBOL_GPL. So this is making > > existing functionality GPL only, which will probably be an issue for > > several out of tree modules that use the fpu. > > > > Could kernel_fpu_begin/end be made plain EXPORT_SYMBOL? > > It can be used by OOT modules as long as they are not under a > proprietary license. The change here is not for me to decide, I added > the x86 maintainers to make their decision. I can make a patch if they > say so. If there are no in-kernel users, the symbols should not be exported anymore. That's nothing new, we have always done this. > On the other hand could we just drop EXPORT_SYMBOL_GPL? I doubt this > helps in any way yet please correct me if I am wrong. Yes, it helps, please leave it as-is. thanks, greg k-h
next prev parent reply index Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <git-mailbomb-linux-master-12209993e98c5fa1855c467f22a24e3d5b8be205@kernel.org> 2019-01-07 22:08 ` Marc Dionne 2019-01-09 11:19 ` Sebastian Andrzej Siewior 2019-01-09 16:52 ` Greg Kroah-Hartman [this message] 2019-01-09 17:09 ` Sebastian Andrzej Siewior 2019-01-09 17:40 ` Marc Dionne 2019-01-10 13:13 ` Greg Kroah-Hartman 2019-01-10 13:11 ` Greg Kroah-Hartman 2019-01-10 17:32 ` Hutter, Tony 2019-01-10 18:07 ` Sebastian Andrzej Siewior 2019-01-10 18:24 ` Greg Kroah-Hartman 2019-01-11 3:18 ` Kash Pande 2019-01-11 5:04 ` Lukas Wunner 2019-01-11 5:40 ` Greg Kroah-Hartman 2019-01-11 18:06 ` Lukas Wunner 2019-01-23 15:58 ` Pavel Machek 2019-01-15 13:01 ` Rene Schickbauer 2019-01-15 13:32 ` Christoph Hellwig 2019-01-15 13:42 ` Greg Kroah-Hartman 2019-01-15 18:51 ` Kash Pande 2019-01-21 12:30 ` Stephan von Krawczynski 2019-01-15 18:26 ` Kash Pande 2019-01-11 3:07 Kash Pande [not found] <20190111054058.GA27966 () kroah ! com> 2019-01-11 6:24 ` Kash Pande
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190109165235.GA8151@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=bigeasy@linutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.c.dionne@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git