From: Sasha Levin <sashal@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
'Stephen Hemminger' <stephen@networkplumber.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"'devel@linuxdriverproject.org'" <devel@linuxdriverproject.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"'marcelo.cerri@canonical.com'" <marcelo.cerri@canonical.com>,
"'apw@canonical.com'" <apw@canonical.com>,
"'olaf@aepfle.de'" <olaf@aepfle.de>,
vkuznets <vkuznets@redhat.com>,
"'jasowang@redhat.com'" <jasowang@redhat.com>,
'Dan B' <dan@structuredgrid.net>
Subject: Re: [PATCH][re-post] vmbus: fix subchannel removal
Date: Wed, 9 Jan 2019 19:20:50 -0500 [thread overview]
Message-ID: <20190110002050.GL166797@sasha-vm> (raw)
In-Reply-To: <PU1P153MB0169D32ECDF37A2DB55AD485BF8B0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Wed, Jan 09, 2019 at 08:56:06PM +0000, Dexuan Cui wrote:
>
>The changes to split ring allocation from open/close, broke
>the cleanup of subchannels. This resulted in problems using
>uio on network devices because the subchannel was left behind
>when the network device was unbound.
>
>The cause was in the disconnect logic which used list splice
>to move the subchannel list into a local variable. This won't
>work because the subchannel list is needed later during the
>process of the rescind messages (relid2channel).
>
>The fix is to just leave the subchannel list in place
>which is what the original code did. The list is cleaned
>up later when the host rescind is processed.
>
>Without the fix, we have a lot of "hang" issues in netvsc when we
>try to change the NIC's MTU, set the number of channels, etc.
>
>Fixes: ae6935ed7d42 ("vmbus: split ring buffer allocation from open")
>Cc: stable@vger.kernel.org
>Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>Signed-off-by: Dexuan Cui <decui@microsoft.com>
Queued, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-01-10 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 20:56 [PATCH][re-post] vmbus: fix subchannel removal Dexuan Cui
2019-01-10 0:20 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110002050.GL166797@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=apw@canonical.com \
--cc=dan@structuredgrid.net \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).