Re: [PATCH] s390/hypfs: Use struct_size() in kzalloc()

From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/hypfs: Use struct_size() in kzalloc()
Date: Thu, 10 Jan 2019 07:59:08 +0100	[thread overview]
Message-ID: <20190110065908.GA7756@osiris> (raw)
In-Reply-To: <20190109173541.GA16953@embeddedor>

On Wed, Jan 09, 2019 at 11:35:41AM -0600, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
> 
> struct foo {
>     int stuff;
>     void *entry[];
> };
> 
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
> 
> Instead of leaving these open-coded and prone to type mistakes, we can now
> use the new struct_size() helper:
> 
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  arch/s390/hypfs/hypfs_diag0c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks!