From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Hutter, Tony" <hutter2@llnl.gov>,
Marc Dionne <marc.c.dionne@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: x86/fpu: Don't export __kernel_fpu_{begin,end}()
Date: Thu, 10 Jan 2019 19:24:13 +0100 [thread overview]
Message-ID: <20190110182413.GA6932@kroah.com> (raw)
In-Reply-To: <20190110180752.f4cnunadzzkev24m@linutronix.de>
On Thu, Jan 10, 2019 at 07:07:52PM +0100, Sebastian Andrzej Siewior wrote:
> On 2019-01-10 17:32:58 [+0000], Hutter, Tony wrote:
> > > But since when did out-of-tree modules use __kernel_fpu_begin? It's an
> > > x86-only thing, and shouldn't really be used by anyone, right?
> >
> > ZFS on Linux uses it for checksums. Its removal is currently breaking ZFS builds against 5.0:
>
> So btrfs uses crc32c() / kernel's crypto API for that and ZFS can't?
> Well the crypto API is GPL only exported so that won't work. crc32c() is
> EXPORT_SYMBOL() so it would work.
> On the other hand it does not look right to provide a EXPORT_SYMBOL
> wrapper around a GPL only interface…
Yes, the "GPL condom" attempt doesn't work at all. It's been shot down
a long time ago in the courts.
My tolerance for ZFS is pretty non-existant. Sun explicitly did not
want their code to work on Linux, so why would we do extra work to get
their code to work properly?
greg k-h
next prev parent reply other threads:[~2019-01-10 18:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <git-mailbomb-linux-master-12209993e98c5fa1855c467f22a24e3d5b8be205@kernel.org>
2019-01-07 22:08 ` x86/fpu: Don't export __kernel_fpu_{begin,end}() Marc Dionne
2019-01-09 11:19 ` Sebastian Andrzej Siewior
2019-01-09 16:52 ` Greg Kroah-Hartman
2019-01-09 17:09 ` Sebastian Andrzej Siewior
2019-01-09 17:40 ` Marc Dionne
2019-01-10 13:13 ` Greg Kroah-Hartman
2019-01-10 13:11 ` Greg Kroah-Hartman
2019-01-10 17:32 ` Hutter, Tony
2019-01-10 18:07 ` Sebastian Andrzej Siewior
2019-01-10 18:24 ` Greg Kroah-Hartman [this message]
2019-01-11 3:18 ` Kash Pande
2019-01-11 5:04 ` Lukas Wunner
2019-01-11 5:40 ` Greg Kroah-Hartman
2019-01-11 18:06 ` Lukas Wunner
2019-01-23 15:58 ` Pavel Machek
2019-01-15 13:01 ` Rene Schickbauer
2019-01-15 13:32 ` Christoph Hellwig
2019-01-15 13:42 ` Greg Kroah-Hartman
2019-01-15 18:51 ` Kash Pande
2019-01-21 12:30 ` Stephan von Krawczynski
2019-01-15 18:26 ` Kash Pande
2019-01-11 3:07 Kash Pande
[not found] <20190111054058.GA27966 () kroah ! com>
2019-01-11 6:24 ` Kash Pande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110182413.GA6932@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bigeasy@linutronix.de \
--cc=hutter2@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).