From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0778C43387 for ; Fri, 11 Jan 2019 06:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C17E520872 for ; Fri, 11 Jan 2019 06:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729735AbfAKGJE (ORCPT ); Fri, 11 Jan 2019 01:09:04 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:33158 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728042AbfAKGJD (ORCPT ); Fri, 11 Jan 2019 01:09:03 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1ghq05-0001ru-Ux; Fri, 11 Jan 2019 14:09:02 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ghq03-0005Lm-8l; Fri, 11 Jan 2019 14:08:59 +0800 Date: Fri, 11 Jan 2019 14:08:59 +0800 From: Herbert Xu To: Zhou Wang Cc: "David S . Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, Shiju Jose , Kenneth Lee , Hao Fang Subject: Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support Message-ID: <20190111060859.k647ltxukywjmi3l@gondor.apana.org.au> References: <1545465105-133138-1-git-send-email-wangzhou1@hisilicon.com> <1545465105-133138-4-git-send-email-wangzhou1@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545465105-133138-4-git-send-email-wangzhou1@hisilicon.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 22, 2018 at 03:51:44PM +0800, Zhou Wang wrote: > > +static struct crypto_alg hisi_zip_zlib = { > + .cra_name = "zlib-deflate", > + .cra_flags = CRYPTO_ALG_TYPE_COMPRESS, > + .cra_ctxsize = sizeof(struct hisi_zip_ctx), > + .cra_priority = 300, > + .cra_module = THIS_MODULE, > + .cra_init = hisi_zip_alloc_comp_ctx, > + .cra_exit = hisi_zip_free_comp_ctx, > + .cra_u = { > + .compress = { > + .coa_compress = hisi_zip_compress, > + .coa_decompress = hisi_zip_decompress > + } > + } > +}; Please do not add any new implementations using the compress interface. You should either use scomp or acomp depending on whether your driver is synchronous or async. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt