From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BE5C43387 for ; Fri, 11 Jan 2019 12:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 470FA20874 for ; Fri, 11 Jan 2019 12:48:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bSLNnv3t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732479AbfAKMso (ORCPT ); Fri, 11 Jan 2019 07:48:44 -0500 Received: from merlin.infradead.org ([205.233.59.134]:57696 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731556AbfAKMso (ORCPT ); Fri, 11 Jan 2019 07:48:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SsvPkT11qi4XPT/NL4tOVWiVW+ueymhxG52BhCyF1Fo=; b=bSLNnv3tWlnZJen6IW9dLe6UA lnIskhb981LV1Yf9wmhpmixZfwdExr7t8y5F3glcNmAdmzyJcSI433/6qubI/KN/i7StNBkHZ+QV8 rBqPFGHUjbQmeRoVJpIAIbxLrFD0AzdL0c2TDI4S0lBBZtx8sjighRKieM4cyTnUGg6Ji/dZwXQCd gEWMr3LlbD/TNb+mvbLaluqoJ9ah8e950o55j5k3GOrqux8evPXtqSn035DNHS+1iycuo+Fs0K2KE /il96CuITLd55qUn+SAnj8CDQ2CWPkYr30u8pXizUzUTJeq3rByeBf2JCKrTlZbCgbjUx2xGKFZ5J bCvo/yYKA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghwEn-0000Xh-JJ; Fri, 11 Jan 2019 12:48:37 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2884D20297683; Fri, 11 Jan 2019 13:48:35 +0100 (CET) Date: Fri, 11 Jan 2019 13:48:35 +0100 From: Peter Zijlstra To: Bart Van Assche Cc: mingo@redhat.com, tj@kernel.org, longman@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys Message-ID: <20190111124835.GP1900@hirez.programming.kicks-ass.net> References: <20190109210204.192109-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109210204.192109-1-bvanassche@acm.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, I spotted this new v6 in my inbox and have rebased to it. On Wed, Jan 09, 2019 at 01:01:48PM -0800, Bart Van Assche wrote: > The changes compared to v5 are: > - Modified zap_class() such that it doesn't try to free a list entry that > is already being freed. I however have a question on this; this seems wrong. Once a list entry is enqueued it should not be reachable anymore. If we can reach an entry after call_rcu() happened, we've got a problem. > - Added a patch that fixes an existing bug in add_chain_cache(). > - Improved the code that reports the size needed for lockdep data structures > further. > - Rebased and retested this patch series on top of kernel v5.0-rc1.