From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545D5C43387 for ; Fri, 11 Jan 2019 14:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 239B72183F for ; Fri, 11 Jan 2019 14:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216109; bh=WfrGHToNUVG4ZCfezeDftm+bdRZq2O70qNp5ZAhxojY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wgDRuK/Zld/pHq5obSjN76HtxLVvAIFgLUL+E4RkOAbnNqnVkxqWM/qR5GxWIs/GP 4L+VSbnMkYqgfmMoJp64HjGxysjDXW+NLDJtUgpIPYBmrZXQ2C+j9mqgK9Xk68Nww0 XkN1M0rRT0gZkaYLO+3uRWD9LWrL10oaaBVbJu1g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733232AbfAKOPI (ORCPT ); Fri, 11 Jan 2019 09:15:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:59106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733219AbfAKOPG (ORCPT ); Fri, 11 Jan 2019 09:15:06 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 007C7217D6; Fri, 11 Jan 2019 14:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216105; bh=WfrGHToNUVG4ZCfezeDftm+bdRZq2O70qNp5ZAhxojY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tM642fcS44mEH7QOc2OVmBCMHyHGUkCAUxVv+DiV0KQ45YEXfo4D1mEIYTjtyx1Ez TDwiY1Vlq1/OwFAZVaxav3Dd9sjdUdjzttspLsNIhSIJnMperSKsJmxa7GVatoOfgj Rt9LGbqVbkRl9MisCrjMgOjpY9fa+mkXrfFLyzWY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maurizio Lombardi , Theodore Tso , stable@kernel.org Subject: [PATCH 3.18 24/47] ext4: missing unlock/put_page() in ext4_try_to_write_inline_data() Date: Fri, 11 Jan 2019 15:08:09 +0100 Message-Id: <20190111130959.162453960@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111130956.170952125@linuxfoundation.org> References: <20190111130956.170952125@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maurizio Lombardi commit 132d00becb31e88469334e1e62751c81345280e0 upstream. In case of error, ext4_try_to_write_inline_data() should unlock and release the page it holds. Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data") Cc: stable@kernel.org # 3.8 Signed-off-by: Maurizio Lombardi Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inline.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -696,8 +696,11 @@ int ext4_try_to_write_inline_data(struct if (!PageUptodate(page)) { ret = ext4_read_inline_page(inode, page); - if (ret < 0) + if (ret < 0) { + unlock_page(page); + put_page(page); goto out_up_read; + } } ret = 1;