From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3867C43387 for ; Fri, 11 Jan 2019 14:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 832E921848 for ; Fri, 11 Jan 2019 14:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217214; bh=y6WOEca+fnxvesbnqnUwYXB/rytkaO0KcAEe4f2vUj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jT2bgmRUXpGspwNedtIf8UJfD235TWdHMlS7n4y/d/CJo3EN8AX9uUu7Wp2DTtZbI oFhF+YPNPMiOrc6hBMAivORhM1O76MKOWjtxpCE2/6AdtdN0d964+RoBKIp94iXgs5 m8d3c/e/8o/UCCl+o5DkS0iJWeFnqUlTjcZv02wo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389677AbfAKOdd (ORCPT ); Fri, 11 Jan 2019 09:33:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:53602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389641AbfAKOdX (ORCPT ); Fri, 11 Jan 2019 09:33:23 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAD9B2063F; Fri, 11 Jan 2019 14:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217203; bh=y6WOEca+fnxvesbnqnUwYXB/rytkaO0KcAEe4f2vUj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2djv2/xhpbBjuqp5iD5a4eXW/WBV8YI8mrdqXHJAw9h/1EWkhjH0FMXPFW5cAtNQb lm4ILfDfoN01fBlBCtUj0KmT6jDkyXbjTzU/OAZqd7C2CCFwX9jGSdLJ+oXmuBlK6S vqUNo6TsDJRoa/K5JQu5KtAGqHLfancewG/AoVvM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yavuz, Tuba" , Dan Carpenter , Takashi Iwai Subject: [PATCH 4.14 081/105] ALSA: cs46xx: Potential NULL dereference in probe Date: Fri, 11 Jan 2019 15:14:52 +0100 Message-Id: <20190111131109.785156783@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131102.899065735@linuxfoundation.org> References: <20190111131102.899065735@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 1524f4e47f90b27a3ac84efbdd94c63172246a6f upstream. The "chip->dsp_spos_instance" can be NULL on some of the ealier error paths in snd_cs46xx_create(). Reported-by: "Yavuz, Tuba" Signed-off-by: Dan Carpenter Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/cs46xx/dsp_spos.c | 3 +++ 1 file changed, 3 insertions(+) --- a/sound/pci/cs46xx/dsp_spos.c +++ b/sound/pci/cs46xx/dsp_spos.c @@ -900,6 +900,9 @@ int cs46xx_dsp_proc_done (struct snd_cs4 struct dsp_spos_instance * ins = chip->dsp_spos_instance; int i; + if (!ins) + return 0; + snd_info_free_entry(ins->proc_sym_info_entry); ins->proc_sym_info_entry = NULL;